Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable "unused" warning for placeholders whose name starts with an underscore #1154

Closed
lars-reimann opened this issue May 5, 2024 · 1 comment · Fixed by #1155
Closed

Disable "unused" warning for placeholders whose name starts with an underscore #1154

lars-reimann opened this issue May 5, 2024 · 1 comment · Fixed by #1155
Assignees
@lars-reimann
Labels
enhancement 💡 New feature or request released Included in a release
Milestone
v0.15.0

Comments

@lars-reimann
Copy link
Member

Is your feature request related to a problem?

Some placeholder may be deliberately unused, so they can be inspected using code lenses. However, we have no way of knowing that, so there's always a warning that the placeholder is unused.

Desired solution

  • Disable the warning for placeholders whose name starts with an underscore
  • Adjust the name convention check accordingly
  • Adjust the documentation about assignments accordingly
  • Add an extra name convention check that names of used placeholders should not start with an underscore.

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response
@lars-reimann lars-reimann added the enhancement 💡 New feature or request label May 5, 2024
@lars-reimann lars-reimann added this to DSL May 5, 2024
@github-project-automation github-project-automation bot moved this to Backlog in DSL May 5, 2024
@lars-reimann lars-reimann self-assigned this May 5, 2024
@lars-reimann lars-reimann moved this from Backlog to In Progress in DSL May 5, 2024
@lars-reimann lars-reimann added this to the v0.15.0 milestone May 5, 2024
@lars-reimann lars-reimann mentioned this issue May 5, 2024
Merged
@lars-reimann lars-reimann linked a pull request May 5, 2024 that will close this issue
feat: disable "unused" warning for placeholders whose name starts with an underscore #1155
Merged
lars-reimann added a commit that referenced this issue May 5, 2024
@lars-reimann
feat: disable "unused" warning for placeholders whose name starts wit…
25781a8 
…h an underscore (#1155)

Closes #1154

### Summary of Changes

Don't show a warning anymore that a placeholder is unused, if its name
starts with an underscore.
@github-project-automation github-project-automation bot moved this from In Progress to ✔️ Done in DSL May 5, 2024
lars-reimann pushed a commit that referenced this issue May 9, 2024
@semantic-release-bot
chore(release): 0.15.0 [skip ci]
cfdbc96 
## [0.15.0](v0.14.1...v0.15.0) (2024-05-09)

### Features

* adjust type cast syntax and restore old precedence ([#1158](#1158)) ([07623fc](07623fc)), closes [#1150](#1150)
* disable "unused" warning for placeholders whose name starts with an underscore ([#1155](#1155)) ([25781a8](25781a8)), closes [#1154](#1154)
* give type casts the lowest precedence ([#1157](#1157)) ([7549fa1](7549fa1)), closes [#1150](#1150)
* integrate version 0.24.0 of the `safe-ds` Python library ([#1162](#1162)) ([1a24a18](1a24a18))
* remove warning that package is empty ([#1159](#1159)) ([b13c5df](b13c5df)), closes [#1153](#1153)
* suggest adding assignment if statement does nothing ([#1156](#1156)) ([11c81b3](11c81b3)), closes [#1142](#1142)
@lars-reimann
Copy link
Member Author

🎉 This issue has been resolved in version 0.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lars-reimann lars-reimann

Labels
enhancement 💡 New feature or request released Included in a release
Projects
DSL
Status: ✔️ Done
Milestone
v0.15.0
Development

Successfully merging a pull request may close this issue.

feat: disable "unused" warning for placeholders whose name starts with an underscore Safe-DS/DSL
1 participant
@lars-reimann