Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable "unused" warning for placeholders whose name starts with an underscore #1155

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented May 5, 2024

Closes #1154

Summary of Changes

Don't show a warning anymore that a placeholder is unused, if its name starts with an underscore.

Copy link

github-actions bot commented May 5, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ MARKDOWN markdown-link-check 1 0 1.0s
✅ REPOSITORY git_diff yes no 0.17s
✅ TYPESCRIPT eslint 2 0 0 4.38s
✅ TYPESCRIPT prettier 2 0 0 0.93s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b469779) to head (7e04dcd).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1155   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          110       110           
  Lines        19201     19231   +30     
  Branches      4102      4110    +8     
=========================================
+ Hits         19201     19231   +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann marked this pull request as ready for review May 5, 2024 08:43
@lars-reimann lars-reimann merged commit 25781a8 into main May 5, 2024
8 checks passed
@lars-reimann lars-reimann deleted the 1154-disable-unused-warning-for-placeholders-whose-name-starts-with-an-underscore branch May 5, 2024 08:43
lars-reimann pushed a commit that referenced this pull request May 9, 2024
## [0.15.0](v0.14.1...v0.15.0) (2024-05-09)

### Features

* adjust type cast syntax and restore old precedence ([#1158](#1158)) ([07623fc](07623fc)), closes [#1150](#1150)
* disable "unused" warning for placeholders whose name starts with an underscore ([#1155](#1155)) ([25781a8](25781a8)), closes [#1154](#1154)
* give type casts the lowest precedence ([#1157](#1157)) ([7549fa1](7549fa1)), closes [#1150](#1150)
* integrate version 0.24.0 of the `safe-ds` Python library ([#1162](#1162)) ([1a24a18](1a24a18))
* remove warning that package is empty ([#1159](#1159)) ([b13c5df](b13c5df)), closes [#1153](#1153)
* suggest adding assignment if statement does nothing ([#1156](#1156)) ([11c81b3](11c81b3)), closes [#1142](#1142)
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable "unused" warning for placeholders whose name starts with an underscore
1 participant