-
-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve window maximized state #670
Conversation
I don't see any reason why we have to install the |
if no default value in settings.js, can not get next time? |
I don’t understand, can you elaborate? |
If I don't add default values in |
Yes, you need to add default values first to register them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot!
Thank you for your guidance, I learned a lot. |
#586
This breaks package, at least portable will not work.
It needs
node_modules/{electron-store,conf,ajv,debounce-fn,mimic-fn,dot-prop,is-obj,env-paths,json-schema-typed,make-dir,semver,onetime,pkg-up,find-up,locate-path,p-locate,p-limit,path-exists,write-file-atomic,imurmurhash,is-typedarray,signal-exit,typedarray-to-buffer,type-fest,p-try,uri-js,……}/**/*",
I'm not sure how much the
……
should be.works:
"!node_modules"
=>"node_modules"