Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve window maximized state #670

Merged
merged 8 commits into from
Mar 22, 2020
Merged

Preserve window maximized state #670

merged 8 commits into from
Mar 22, 2020

Conversation

ivysrono
Copy link
Contributor

@ivysrono ivysrono commented Mar 21, 2020

#586
This breaks package, at least portable will not work.
It needs node_modules/{electron-store,conf,ajv,debounce-fn,mimic-fn,dot-prop,is-obj,env-paths,json-schema-typed,make-dir,semver,onetime,pkg-up,find-up,locate-path,p-locate,p-limit,path-exists,write-file-atomic,imurmurhash,is-typedarray,signal-exit,typedarray-to-buffer,type-fest,p-try,uri-js,……}/**/*",
I'm not sure how much the …… should be.
works: "!node_modules" => "node_modules"

@yishn
Copy link
Member

yishn commented Mar 21, 2020

I don't see any reason why we have to install the electron-store dependency?

@ivysrono
Copy link
Contributor Author

I don't see any reason why we have to install the electron-store dependency?

if no default value in settings.js, can not get next time?

@yishn
Copy link
Member

yishn commented Mar 22, 2020

I don’t understand, can you elaborate?

@ivysrono
Copy link
Contributor Author

If I don't add default values in settings.js , I get null after re-launch.
This is the reason I import electron-store at first.

@yishn
Copy link
Member

yishn commented Mar 22, 2020

Yes, you need to add default values first to register them.

src/setting.js Outdated Show resolved Hide resolved
src/setting.js Outdated Show resolved Hide resolved
src/main.js Outdated Show resolved Hide resolved
@yishn yishn linked an issue Mar 22, 2020 that may be closed by this pull request
Copy link
Member

@yishn yishn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@yishn yishn merged commit 34c37b1 into SabakiHQ:master Mar 22, 2020
@ivysrono ivysrono deleted the patch-1 branch March 22, 2020 11:27
@ivysrono
Copy link
Contributor Author

Thank you for your guidance, I learned a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Preserve window maximized state
2 participants