Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve window maximized state #586

Closed
ivysrono opened this issue Jun 22, 2019 · 5 comments · Fixed by #670
Closed

Preserve window maximized state #586

ivysrono opened this issue Jun 22, 2019 · 5 comments · Fixed by #670
Labels
enhancement good first issue

Comments

@ivysrono
Copy link
Contributor

as title.
@yishn
Copy link
Member

yishn commented Jun 22, 2019

We should probably save the window state along with window dimensions when closing.

@yishn yishn changed the title feature request: add config to set window maximize Preserve window maximized state Jun 22, 2019
@mdm
Copy link

mdm commented Oct 8, 2019

I'd like to work on this if nobody else is.

@yishn yishn assigned mdm Oct 9, 2019
@yishn
Copy link
Member

yishn commented Feb 29, 2020

I'm unassigning this issue since there are no updates.

@yishn yishn unassigned mdm Feb 29, 2020
This was referenced Mar 17, 2020
Closed
Merged
@ivysrono
Copy link
Contributor Author

#670

@yishn
Copy link
Member

yishn commented Mar 21, 2020

Please don't close this issue until a PR is merged.

@yishn yishn reopened this Mar 21, 2020
@yishn yishn linked a pull request Mar 22, 2020 that will close this issue
Preserve window maximized state #670
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preserve window maximized state
3 participants
@mdm @ivysrono @yishn