Goban grid lines are much blurrier in 20.1

[rooklift]

http://i.imgur.com/JxHh6nW.png

On the left is 20.0, on the right is 20.1.

The lines on the left are much crisper and sharper.

Although this is the default theme, things are also like this on my own theme. Did something change in how lines are drawn?

[yishn]

No, the way how lines are drawn didn't change, but I did upgrade Electron to v1.6.1, which comes with an upgraded Chrome version, which might be responsible for this...

I'm noticing that the bottom bar in v0.20.1 is bigger than in v0.20.0, which might indicate that the zoom level of the web page has changed. Your Windows has a larger zoom level than Windows has as standard. It might be the case that Electron v1.6.1 is adjusting the zoom level depending on your system settings resulting in all non-vector images being blurry, but I'm really just guessing here...

[rooklift]

That'll be it, I'm sure. I have everything at 125% size in the Display control panel.

[yishn]

Maybe it's a good idea to replace all grid line images with vector images. It won't fix the wood texture being blurry, though.

[rooklift]

Uh, I wonder how much trouble it would be to add some sort of workaround as an option in the settings.json, where I could ask for 0.8 size to counteract it, and then the code would do something like:

let contents = win.webContents;
contents.setZoomFactor(0.8);         // Or whatever is set...

I'll try and submit a pull request if I can make it work.

[yishn]

That would be very quick and hacky; I can add a settings key for that. 😀

[yishn]

It's done, and the key's name is debug.zoom_factor. I'll keep this issue open for the vector images of the grid lines.

[rooklift]

Thanks, good to have.

Edit: Yes, I can confirm this fixes it.

[rooklift]

Although the bad news is that the saved window size now doesn't really work.

[yishn]

Can you elaborate on that?

[rooklift]

When I set to 0.8, the window gets bigger every time I open the app.

[yishn]

I've hopefully added a fix for that, can you try it?

[rooklift]

Yes I think that's working now.

[rooklift]

It's a minor thing, but (with a setting of 0.8) the menu in the bottom right (Pass, Resign, Edit, etc) is placed too far right and down.

The cause is view.js lines 1146-1147 though I'm not sure how to deal with it.

[yishn]

I guess everything that measures the DOM for menu placement is bound to have some errors. I don't think this can be fixed... Unless we open the menu at the current mouse position instead.

[rooklift]

Making it

    Math.round($('#headermenu').offset().left * setting.get('debug.zoom_factor')),
    Math.round($('header').offset().top * setting.get('debug.zoom_factor'))

I think works. Although I don't know how many places in the code would need to be littered with this stuff. Perhaps best not to.

(I've been experimenting with Electron a little myself and find this interaction with Windows scaling (if the user, like me, has chosen something like 125% system-wide) to be annoying...)

Still, I think I can probably make some image files for my own use that have a tolerable result, then I can turn debug.zoom_factor back to 1.0.