lib/portus: do not remove all the repos if one fails

lib/portus/registry_client.rb

@@ -115,8 +115,7 @@ def add_tags(repositories)
       result = []
       repositories.each do |repo|
         res = perform_request("#{repo}/tags/list")
-        return [] if res.code.to_i != 200
-        result << JSON.parse(res.body)
+        result << JSON.parse(res.body) if res.code.to_i == 200
       end
       result
     end

spec/lib/portus/registry_client_spec.rb

@@ -286,6 +286,24 @@ def fetch_link_test(header)
       end
     end
 
+    it "does not remove all repos just because one of them is failing" do
+      create(:registry)
+      create(:admin, username: "portus")
+
+      VCR.use_cassette("registry/get_registry_one_fails", record: :none) do
+        registry = Portus::RegistryClient.new(
+          registry_server,
+          false,
+          "portus",
+          Rails.application.secrets.portus_password)
+
+        catalog = registry.catalog
+        expect(catalog.length).to be 1
+        expect(catalog[0]["name"]).to eq "busybox"
+        expect(catalog[0]["tags"]).to match_array(["latest"])
+      end
+    end
+
     it "fails if this version of registry does not implement /v2/_catalog" do
       VCR.use_cassette("registry/get_missing_catalog_endpoint", record: :none) do
         registry = Portus::RegistryClient.new(