This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
lib/portus: do not remove all the repos if one fails #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, the `RegistryClient#catalog` method can erase the DB of all the repos. This happens when, for some unexpected reason, the `RegistryClient#add_tags` method fails at retrieving one repository. In this case, before this patch this method just returned an empty array. After this patch, repositories that are not found will simply not be added, but the method will go on adding tags to other repositories. See SUSE#663 Signed-off-by: Miquel Sabaté Solà <[email protected]>
|
This should be cherry-picked into |
|
LGTM, please take care of the cherry-pick |
mssola
added a commit
that referenced
this pull request
Jan 22, 2016
lib/portus: do not remove all the repos if one fails
|
Done |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the
RegistryClient#catalogmethod can erase the DB of all therepos. This happens when, for some unexpected reason, the
RegistryClient#add_tagsmethod fails at retrieving one repository. In thiscase, before this patch this method just returned an empty array. After this
patch, repositories that are not found will simply not be added, but the
method will go on adding tags to other repositories.
See #663
Signed-off-by: Miquel Sabaté Solà [email protected]