Release/ADAPT-000 Gallery/Campaign page logo fix #235

yvonnetangsu · 2021-11-17T18:51:43Z

READY FOR REVIEW

(Edit the above to reflect status)

Summary

Prepare release with fixes that Patrick requested to go live before 11/20

Review By (Date)

When does this need to be reviewed by?

Criticality

How critical is this PR on a 1-10 scale? Also see Severity Assessment.
E.g., it affects one site, or every site and product?

Review Tasks

Setup tasks and/or behavior to test

Check out this branch
Navigate to...
Verify...

Front End Validation

Is the markup using the appropriate semantic tags and passes HTML validation?
Cross-browser testing has been performed?
Automated accessibility scans performed?
Manual accessibility tests performed?
Design is approved by @ user?

Backend / Functional Validation

Code

Are the naming conventions following our standards?
Does the code have sufficient inline comments?
Is there anything in this code that would be hidden or hard to discover through the UI?
Are there any code smells?
Are tests provided? eg (unit, behat, or codeception)

Code security

Are all forms properly sanitized?
Any obvious security flaws or new areas for attack?

General

Is there anything included in this PR that is not related to the problem it is trying to solve?
Is the approach to the problem appropriate?

Affected Projects or Products

Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

JIRA ticket(s)
Other PRs
Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
Anyone who should be notified? (@mention them here)

Resources

AMP Tool
Accessibility Manual Test Script
HTML Validator
Browserstack and link to Browserstack Credentials

…216)

ADAPT-3203: Campaign hero serif variant (#222)

ADAPT-3172: Update Node version to 16 from 15 (#224)

* Allow pages to be removed from search indexing and sitemap * Omit noindex entites from algolia indexing Co-authored-by: Sherakama <[email protected]>

* Optionally render logo image in campaign header when set * Refactor custom logo image out of lockup and into cmapaign header * Cleanup Co-authored-by: Sherakama <[email protected]>

Co-authored-by: Sherakama <[email protected]> Co-authored-by: Shea McKinney <[email protected]>

* graphQL error fixup * Add resolveLinks = url * Use storyblok-js-client version 4.1.3

…header image also (#232)

yvonnetangsu · 2021-11-17T20:56:15Z

package.json

@@ -2,7 +2,7 @@
  "name": "giving-to-stanford",
  "private": true,
  "description": "Giving to Stanford",
-  "version": "0.1.0",
+  "version": "0.1.1",


Not super familiar the the release process on Giving. LMK if this looks right 🤔

I was just checking the branch diff. S'all good.

Awesome, thanks @sherakama !

yvonnetangsu · 2021-11-18T21:10:19Z

@sherakama Thanks for adding the workflow files! Is there a chance we could roll this out today? I'm thinking that since this is going live this Saturday and I'm out next week, it might be good to roll this out a day earlier so we have tomorrow to fix anything if needed 🤔

sherakama · 2021-11-19T17:27:08Z

@sherakama Thanks for adding the workflow files! Is there a chance we could roll this out today? I'm thinking that since this is going live this Saturday and I'm out next week, it might be good to roll this out a day earlier so we have tomorrow to fix anything if needed 🤔

Let's dual release today during our 1pm session.

yvonnetangsu · 2021-11-19T17:30:53Z

@sherakama Thanks for adding the workflow files! Is there a chance we could roll this out today? I'm thinking that since this is going live this Saturday and I'm out next week, it might be good to roll this out a day earlier so we have tomorrow to fix anything if needed 🤔

Let's dual release today during our 1pm session.

Awesome - thanks, @sherakama ! 😄

sherakama and others added 17 commits August 9, 2021 11:22

ADAPT-000: Remove production search things like sitemap and Algolia.

17afd7d

ADAPT-000: Add basic auth.

0afffcc

fixup! header values.

2e97ff2

fixup! header values.

9a928ce

Conditionally render oodCampaignHeader homelink based on blok field (#…

0d89531

…216)

ADAPT-3203: Campaign hero serif variant (#222)

cfb3375

ADAPT-3203: Campaign hero serif variant (#222)

ADAPT-3172: Update Node version to 16 from 15 (#224)

0eb3d49

ADAPT-3172: Update Node version to 16 from 15 (#224)

ADAPT-3204 ADAPT-3205 | @mattanglin | noindex page option (#225)

8c58756

* Allow pages to be removed from search indexing and sitemap * Omit noindex entites from algolia indexing Co-authored-by: Sherakama <[email protected]>

ADAPT-3201 | @mattanglin | campaign header logo (#223)

a4c7933

* Optionally render logo image in campaign header when set * Refactor custom logo image out of lockup and into cmapaign header * Cleanup Co-authored-by: Sherakama <[email protected]>

Merge branch 'main' into dev

0e59300

ADAPT-3305: Added x-frame-options header. (#229)

0c8c5ab

ADAPT-3147 | @mattanglin | pipeline status checks (#221)

07c87b6

Co-authored-by: Sherakama <[email protected]> Co-authored-by: Shea McKinney <[email protected]>

ADAPT-000: GraphQL error and storyblok-js-client fixup (#231)

eb5dafa

* graphQL error fixup * Add resolveLinks = url * Use storyblok-js-client version 4.1.3

Remove max width of gallery slideshow on mobile (#233)

9f03e9c

Tweak campaign hero logo max width and padding (#234)

352e807

Have vertical focus schema available for non-fullwidth interior page …

e8abf5a

…header image also (#232)

version number

3efea62

yvonnetangsu requested a review from sherakama November 17, 2021 20:52

sherakama changed the base branch from main to dev November 17, 2021 20:54

yvonnetangsu commented Nov 17, 2021

View reviewed changes

sherakama changed the base branch from dev to main November 17, 2021 20:58

yvonnetangsu requested a review from mattanglin November 17, 2021 21:01

ADAPT-000: Add workflow files.

004ce24

github-actions bot added the size/xl label Nov 17, 2021

sherakama added patch patch major major and removed patch patch labels Nov 17, 2021

ADAPT-000: Add workflow files.

f666727

github-actions bot added the patch patch label Nov 17, 2021

sherakama approved these changes Nov 19, 2021

View reviewed changes

yvonnetangsu merged commit 7fd105e into main Nov 19, 2021

yvonnetangsu deleted the release/ADAPT-000_gallery-campaign-fix branch November 19, 2021 21:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release/ADAPT-000 Gallery/Campaign page logo fix #235

Release/ADAPT-000 Gallery/Campaign page logo fix #235

yvonnetangsu commented Nov 17, 2021 •

edited

Loading

yvonnetangsu Nov 17, 2021

sherakama Nov 17, 2021

yvonnetangsu Nov 17, 2021

yvonnetangsu commented Nov 18, 2021 •

edited

Loading

sherakama commented Nov 19, 2021

yvonnetangsu commented Nov 19, 2021

Release/ADAPT-000 Gallery/Campaign page logo fix #235

Release/ADAPT-000 Gallery/Campaign page logo fix #235

Conversation

yvonnetangsu commented Nov 17, 2021 • edited Loading

READY FOR REVIEW

Summary

Review By (Date)

Criticality

Review Tasks

Setup tasks and/or behavior to test

Front End Validation

Backend / Functional Validation

Code

Code security

General

Affected Projects or Products

Associated Issues and/or People

Resources

yvonnetangsu Nov 17, 2021

Choose a reason for hiding this comment

sherakama Nov 17, 2021

Choose a reason for hiding this comment

yvonnetangsu Nov 17, 2021

Choose a reason for hiding this comment

yvonnetangsu commented Nov 18, 2021 • edited Loading

sherakama commented Nov 19, 2021

yvonnetangsu commented Nov 19, 2021

yvonnetangsu commented Nov 17, 2021 •

edited

Loading

yvonnetangsu commented Nov 18, 2021 •

edited

Loading