Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADAPT-000: GraphQL error and storyblok-js-client fixup #231

Merged
merged 3 commits into from
Nov 9, 2021
Merged

ADAPT-000: GraphQL error and storyblok-js-client fixup #231

merged 3 commits into from
Nov 9, 2021

Conversation

yvonnetangsu
Copy link
Member

@yvonnetangsu yvonnetangsu commented Nov 9, 2021 •
edited
Loading

READY FOR REVIEW

Summary

  • Fix graphql error for useSiteMetadata hook
  • Ran into this error when doing npm run develop while reviewing the focal point branch
    Screen Shot 2021-11-09 at 10 39 53 AM
  • Borrow code from saa-alumni repo which seems to work
  • Lock in storyblok-js-client at version 4.1.3 to avoid link issue (with /default in the internal links)

Review By (Date)

  • When does this need to be reviewed by?

Criticality

  • How critical is this PR on a 1-10 scale? Also see Severity Assessment.
  • E.g., it affects one site, or every site and product?

Review Tasks

Setup tasks and/or behavior to test

  1. Check the Netlify preview and that all internal links behave normally
  2. Check that npm run develop works without GraphQL error
  3. Look at code

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

yvonnetangsu
yvonnetangsu commented Nov 9, 2021
View reviewed changes
gatsby-config.js
@@ -115,6 +125,7 @@ module.exports = {
accessToken: process.env.GATSBY_STORYBLOK_ACCESS_TOKEN,
homeSlug: "home",
resolveRelations: storyblokRelations,
resolveLinks: 'url',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While looking at the netlify preview, I found that it has that same weird /default in the Main nav link issue we had on alumni, so I added this bit here, but I'm still seeing that problem on the Netlify preview. @mattanglin or @sherakama do you remember what else we had to do to fix that problem? I believe Nathan also mentioned that he ran into this issue as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yvonnetangsu To fix this we need to manually add the [email protected] (locked to the version) to our package.json. It's a dependency of the gatsby-source-storyblok package, but they published some breaking changes in v4.1.4...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh that was it. Will do. Thanks, @mattanglin !

@yvonnetangsu yvonnetangsu changed the title ADAPT-000: GraphQL error fixup ADAPT-000: GraphQL error and storyblok-js-client fixup Nov 9, 2021
mattanglin
mattanglin approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@mattanglin mattanglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍🏼

@yvonnetangsu yvonnetangsu merged commit eb5dafa into dev Nov 9, 2021
@yvonnetangsu yvonnetangsu deleted the ADAPT-000-siteurl branch November 9, 2021 19:43
yvonnetangsu added a commit that referenced this pull request Nov 9, 2021
@yvonnetangsu
Merge branch 'dev' into ADAPT-2726-focal-point
c926e9d 
* dev:
  ADAPT-000: GraphQL error and storyblok-js-client fixup (#231)
  ADAPT-3147 | @mattanglin | pipeline status checks (#221)

# Conflicts:
#	package-lock.json
#	src/components/media/aspectRatioImage.js
#	src/components/media/fullWidthImage.js
#	src/components/media/storyImage.js
#	src/utilities/transformImage.js
sherakama
sherakama reviewed Nov 10, 2021
View reviewed changes
package.json
@@ -40,6 +40,7 @@
"react-slick": "^0.28.1",
"sanitize-html": "^2.3.3",
"slick-carousel": "^1.8.1",
"storyblok-js-client": "4.1.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherakama sherakama sherakama left review comments

@mattanglin mattanglin mattanglin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yvonnetangsu @sherakama @mattanglin