Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADAPT-000: Remove link-underline utility class #851

Merged
merged 9 commits into from
Sep 17, 2021
Merged

ADAPT-000: Remove link-underline utility class #851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7fc7bb8
ADAPT-000: Fix CSS in JS Syntax.
sherakama Sep 17, 2021
499ff18
Update package.json
sherakama Sep 17, 2021
39fdc52
ADAPT-000: Fix CSS in JS Syntax.
sherakama Sep 17, 2021
a82837e
Merge branch 'task/underline' of github.com:SU-SWS/decanter into task…
sherakama Sep 17, 2021
756c285
ADAPT-000: Fix CSS in JS Syntax.
sherakama Sep 17, 2021
eafc8b7
ADAPT-000: Changeup for JIT mode
sherakama Sep 17, 2021
1d505db
Removed link-underline utility as it was a bad idea in the first place.
sherakama Sep 17, 2021
aa3a6e9
ADAPT-000: Add upgrade notes.
sherakama Sep 17, 2021
ea7734b
ADAPT-000: Change to nested variant states on custom link utility cla…
sherakama Sep 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
15
16
7 changes: 7 additions & 0 deletions UPGRADE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Upgrade

Upgrade from version 7.0.0-beta.0 to 7.0.0-beta.1
-------------------------------------------
- Removed `su-link-underline`, `su-link-no-underline`, and `.su-link` nested variant states as they don't play nice with JIT mode.
- Replace this functionality by installing and using the tailwind children varients plugin within your project and using it with the no-underline utility.
- https://github.com/benface/tailwindcss-children
- https://tailwindcss.com/docs/text-decoration#no-underline

Upgrade from version 7.0.0-alpha to 7.0.0-beta
-------------------------------------------
- Renamed `su-input-base` to `su-input`
Expand Down
14 changes: 13 additions & 1 deletion dist/decanter-base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* plugins.
*/

/*! tailwindcss v2.2.7 | MIT License | https://tailwindcss.com
/*! tailwindcss v2.2.15 | MIT License | https://tailwindcss.com
*/

/*! modern-normalize v1.1.0 | MIT License | https://github.com/sindresorhus/modern-normalize */
Expand Down Expand Up @@ -472,6 +472,18 @@ button,
cursor: pointer;
}

/**
* Override legacy focus reset from Normalize with modern Firefox focus styles.
*
* This is actually an improvement over the new defaults in Firefox in our testing,
* as it triggers the better focus styles even for links, which still use a dotted
* outline in Firefox by default.
*/

:-moz-focusring {
outline: auto;
}

table {
border-collapse: collapse;
}
Expand Down
Loading