ADAPT-000: Remove link-underline utility class

[sherakama]

READY FOR REVIEW

Summary

• Removes link-underline utility classes as they don't work for JIT mode
• Updated to node version 16 and updated a few packages

Steps to Test

1. Review code changes
2. Review preview build
3. Review upgrade.md dox

Affected Projects or Products

• Decanter React
• Alumni

Associated Issues and/or People

• JIRA ticket
• Other PRs
• Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
• Anyone who should be notified? (@mention them here)

See Also

• PR Checklist

[yvonnetangsu]

Just that one question - the rest looks good to me!

[sherakama]

Aborting as there is no good way to make this plugin work with JIT mode. We are going to have to remove it.

[yvonnetangsu]

Aborting as there is no good way to make this plugin work with JIT mode. We are going to have to remove it.

Aww...bummer. Thank you for testing though! We'll find ways to work around that.

[sherakama]

@rebeccahongsf @yvonnetangsu re-ready for review.

[yvonnetangsu]

Thanks for investigating, @sherakama . GTG - bummer this doesn't work with JIT.
I suspect we also need to remove the link-color and link-fontweight utilities, but we could address that in another PR perhaps?
https://github.com/SU-SWS/decanter/blob/v7/src/plugins/utilities/link/link.js
https://github.com/SU-SWS/decanter/blob/v7/src/plugins/utilities/link/link-fontweight.js

[sherakama]

Font weight should be fine but the hovers in link will have to go...

[sherakama]

Thanks for investigating, @sherakama . GTG - bummer this doesn't work with JIT.
I suspect we also need to remove the link-color and link-fontweight utilities, but we could address that in another PR perhaps?
v7/src/plugins/utilities/link/link.js
v7/src/plugins/utilities/link/link-fontweight.js

@yvonnetangsu,

Good catch. The font-weight should be fine as it doesn't have the hacky variant classes (hover, focus) but the others have had their hacks removed. I restored the main selector for now but these should really be considered deprecated at this point. We will remove them from our other work first before completely removing them from this package.

[yvonnetangsu]

@sherakama This looks good to me. Thank you for the fix!