Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change @type-f font size from 0.8em to 0.9em and remove uppercase style #609

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

yvonnetangsu
Copy link
Member

@yvonnetangsu yvonnetangsu commented Jan 17, 2020

READY FOR REVIEW

Summary

  • Change @type-f font size from 0.8em to 0.9em and remove uppercase style as requested by @kerri-augenstein
  • This will change the superheadline in the card and hero components.

Needed By (Date)

  • Sooner the better

Urgency

  • Sooner the better

Steps to Test

  1. Go to https://pr609-saoppsvp7getzi3bzr4irxrw1sqghbvo.tugboat.qa/page/brand-design-elements-typography/
  2. See "Display Type F" section and check the font size and style is as requested.
  3. Go to
    https://pr609-saoppsvp7getzi3bzr4irxrw1sqghbvo.tugboat.qa/component/composite-card/
    https://pr609-saoppsvp7getzi3bzr4irxrw1sqghbvo.tugboat.qa/component/composite-hero/
  4. Check that the superheadline in the card and hero components style is as requested.

Affected Projects or Products

  • D8
  • Decanter

Associated Issues and/or People

@sherakama sherakama temporarily deployed to Tugboat January 17, 2020 23:11 Destroyed
@yvonnetangsu
Copy link
Member Author

@kerri-augenstein Please check at mobile breakpoints and see if font size needs to be finetuned.

Copy link
Member

@sherakama sherakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code approved. Just waiting on visual approval from @kerri-augenstein.

@kerri-augenstein
Copy link

@yvonnetangsu @sherakama I followed the other steps to test, instead of the tugboat, and we're good. Looks great! Thank you!

@sherakama
Copy link
Member

@kerri-augenstein @yvonnetangsu

Tugboat seems to take a few moments to "wake up". Wait 10 seconds after the first "tubgoat error" and then do a shift + refresh of your browser and it should be GTG.

@yvonnetangsu
Copy link
Member Author

@kerri-augenstein @yvonnetangsu

Tugboat seems to take a few moments to "wake up". Wait 10 seconds after the first "tubgoat error" and then do a shift + refresh of your browser and it should be GTG.

Looks like @kerri-augenstein approved - see above message. Please feel free to merge.

@sherakama sherakama merged commit 730cfe3 into master Jan 22, 2020
@sherakama sherakama deleted the 603-display-f branch January 22, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants