Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change display-f font size and style #603

Closed
yvonnetangsu opened this issue Jan 7, 2020 · 4 comments
Closed

Change display-f font size and style #603

yvonnetangsu opened this issue Jan 7, 2020 · 4 comments
Assignees
@yvonnetangsu

Comments

@yvonnetangsu
Copy link
Member

yvonnetangsu commented Jan 7, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
Change the display-f mixin font size from 0.8em to 0.9em and remove the all caps text transform which allows for more flexibility and is easier to read as suggested by @kerri-augenstein .
@yvonnetangsu
Copy link
Member Author

@kerri-augenstein Just want to confirm with you that this change will affect our hero and card components since they both use the @display-f mixin. Is this ok?

@kerri-augenstein
Copy link

@yvonnetangsu yes! i would love that!

@yvonnetangsu yvonnetangsu self-assigned this Jan 17, 2020
@yvonnetangsu yvonnetangsu mentioned this issue Jan 17, 2020
Merged
@yvonnetangsu
Copy link
Member Author

@kerri-augenstein pull request is up - please take a look.
#609
Just follow the links in "Steps to Test" :)

@yvonnetangsu
Copy link
Member Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yvonnetangsu yvonnetangsu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kerri-augenstein @yvonnetangsu