Add 4 new @modular-spacing steps (#6 to #9) and modify 2 existing steps (#3 and #4) #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvonnetangsu
changed the title
yvonnetangsu
added a commit
that referenced
this pull request
Oct 2, 2019
yvonnetangsu
added a commit
that referenced
this pull request
Oct 2, 2019
yvonnetangsu
added a commit
that referenced
this pull request
Oct 29, 2019
* master: (28 commits) Updated packages and configuration files. (#527) Use rem instead of em for big button font size so it doesn't blow up in sections if we set a large base font size; finetune big button padding for smaller breakpoints (#522) Change sizes of link icons to use px instead of em to prevent occasional clipping (#523) D8CORE-628: Add caption option to hero banner. (#517) Use percentage for html root font size instead of px so people can scale up using browser font size preferences (#526) Mixins documention update — @centered-column (#448) Adds Tugboat and fixes npm dependencies. (#518) Update _hero.scss (#513) Create Aspect Ratio Mixin (#445) Adding global footer variants and link tweaks for legibility, change layout at MD breakpoint to match Figma (#500) Updated package and lock files. Add parameter to @link-icon to adjust vertical position of icon and different options for $animate parameter (#504) Delete card-2019-08-28.twig (#506) Update _input.scss (#507) Scale down type-a and type-b font size at xs and sm breakpoints, repurpose splash font and minor typography tweaks (#498) Add 4 new @modular-spacing steps (#6 to #9) and modify 2 existing steps (#3 and #4) (#503) add su- prefix to Decanter core and component variables, deprecate old names (#452) Includevar (#496) Put appearance back for select dropdowns (#479) Split input.scss into several files and add new input-base placeholder (#476) ... # Conflicts (resolved manually) # core/dist/css/decanter.css # core/src/scss/components/card/_card.scss # core/src/scss/components/card/index.scss # core/src/scss/utilities/placeholders/components/_card.scss # core/src/templates/components/card/card.twig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
New spacers:
@modular-spacing 4 (change)
3XL: Base * 3.2
@modular-spacing 5 (change)
4XL: Base * 4
@modular-spacing 6 (new)
5XL: Base * 5
@modular-spacing 7 (new)
6XL: Base * 6
@modular-spacing 8 (new)
7XL: Base * 7
@modular-spacing 9 (new)
8XL: Base * 9
Needed By (Date)
Urgency
Steps to Test
@modular-spacingmixin by passing in the newly added integer steps, e.g., inscss/components/_cards.scss, apply@modular-spacing('padding', 9 8 7 6)to.su-card__contents, check the rendered padding value matches the ones in the screenshot above at all 3 breakpoint ranges.Affected Projects or Products
Associated Issues and/or People