Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in between spacers + larger spacer (3.5, 4.5, 6) #492

Closed
kerri-augenstein opened this issue Sep 3, 2019 · 5 comments
Closed

Add in between spacers + larger spacer (3.5, 4.5, 6) #492

kerri-augenstein opened this issue Sep 3, 2019 · 5 comments
Assignees

Comments

@kerri-augenstein
Copy link

kerri-augenstein commented Sep 3, 2019

Size of spacers between 3 and 4 are too big, need to change these spacers, and add additional spacers — 6, 7, and 8 —to account for wider range of spacing needs.

Modular Scale 4
3XL: Base *3.2

Modular Scale 5
4XL: Base 4

Modular Scale 6
5XL: Base 5

Modular Scale 7
6XL: Base 6

Modular Scale 8
7XL: Base 7

Modular Scale 9
8XL: Base 9

Screen Shot 2019-09-18 at 3 54 23 PM

@kerri-augenstein kerri-augenstein added the Needs Design Needs hi-fi design label Sep 3, 2019
@kerri-augenstein kerri-augenstein self-assigned this Sep 3, 2019
@kerri-augenstein kerri-augenstein removed the Needs Design Needs hi-fi design label Sep 3, 2019
@kerri-augenstein
Copy link
Author

Ready for frontend dev

@kerri-augenstein
Copy link
Author

@yvonnetangsu I tweaked this ticket with the proper integer value jumps. Could you take a look and let me know if you would have everything that you would need to make the changes and additions?

@yvonnetangsu
Copy link
Member

yvonnetangsu commented Sep 12, 2019

@kerri-augenstein @sherakama I'm thinking about getting rid of the media queries for modular-spacing at the lower end, since every time we use @modular-spacing, it generates 3 media queries - 1) the values are practically the same for all three breakpoint ranges 2) extra code and 3) makes it harder to override when needed. What do you guys think?
Screen Shot 2019-09-12 at 11 07 52 AM

@yvonnetangsu
Copy link
Member

I've decided to leave out the above part "getting rid of the media queries for modular-spacing at the lower end" since we rarely use the mixin at these lower end values anyway.

@sherakama
Copy link
Member

Ok, great thanks Yvonne.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants