Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

439 improve current media item tracker #440

Merged
merged 13 commits into from
Feb 15, 2024

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Feb 12, 2024

Pull request

Description

The goal of this PR is to improve custom media item tracking. It fixe an issue where MediaItemTracker doesn't start when a given MediaItem with mediaId and url is set.

Changes made

  • MediaItemTracker start and stop accordingly when either input MediaItem contain mediaId and url.
  • MediaItemTracker.update is called correctly when data has changed.
  • Add or remove tracker data during playback doesn't start or stop tracker.
  • MediaItemTrackerData is now immutable to follow MediaItem immutability.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ force-pushed the 439-improve-current-media-item-tracker branch from c288d87 to 8b710b3 Compare February 12, 2024 12:52
Copy link

github-actions bot commented Feb 12, 2024

Code Coverage

Overall Project 21.21% -1.92% 🟢
Files changed 21.38% 🟢

Module Coverage
:pillarbox-player 26.24% -5.29% 🟢
:pillarbox-core-business 25.77% -1.07% 🟢
Files
Module File Coverage
:pillarbox-player MediaItemTrackerData.kt 90% -10% 🟢
MediaItem.kt 88.1% 🟢
PillarboxPlayer.kt 11.39% -2.22% 🟢
CurrentMediaItemTracker.kt 0% -58.65% 🟢
PillarboxMediaSource.kt 0% -9.78% 🟢
:pillarbox-core-business MediaCompositionMediaItemSource.kt 17.06% -8.94% 🟢

@MGaetan89 MGaetan89 linked an issue Feb 12, 2024 that may be closed by this pull request
2 tasks
@StaehliJ StaehliJ enabled auto-merge February 13, 2024 05:46
@StaehliJ StaehliJ requested a review from MGaetan89 February 13, 2024 06:06
Copy link
Member

@MGaetan89 MGaetan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍🏻
I just have a couple of clarification questions, and pushed some minor changes.

@StaehliJ StaehliJ added this pull request to the merge queue Feb 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 13, 2024
@StaehliJ StaehliJ added this pull request to the merge queue Feb 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 15, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue Feb 15, 2024
Merged via the queue into main with commit 1d40aaa Feb 15, 2024
9 checks passed
@MGaetan89 MGaetan89 deleted the 439-improve-current-media-item-tracker branch February 15, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve CurrentMediaItemTracker
2 participants