-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
439 improve current media item tracker #440
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StaehliJ
force-pushed
the
439-improve-current-media-item-tracker
branch
from
February 12, 2024 12:52
c288d87
to
8b710b3
Compare
Code Coverage
Files
|
2 tasks
MGaetan89
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good 👍🏻
I just have a couple of clarification questions, and pushed some minor changes.
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/tracker/CurrentMediaItemTracker.kt
Outdated
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/tracker/CurrentMediaItemTracker.kt
Outdated
Show resolved
Hide resolved
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Feb 13, 2024
MGaetan89
approved these changes
Feb 14, 2024
MGaetan89
approved these changes
Feb 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
The goal of this PR is to improve custom media item tracking. It fixe an issue where
MediaItemTracker
doesn't start when a givenMediaItem
withmediaId
andurl
is set.Changes made
MediaItemTracker
start and stop accordingly when either input MediaItem containmediaId
andurl
.MediaItemTracker.update
is called correctly when data has changed.MediaItemTrackerData
is now immutable to followMediaItem
immutability.Checklist
main
branch.