Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CurrentMediaItemTracker #439

Closed
2 tasks
StaehliJ opened this issue Feb 8, 2024 · 0 comments · Fixed by #440
Closed
2 tasks

Improve CurrentMediaItemTracker #439

StaehliJ opened this issue Feb 8, 2024 · 0 comments · Fixed by #440
Assignees
Milestone

Comments

@StaehliJ
Copy link
Contributor

StaehliJ commented Feb 8, 2024

As a user / integrator I want to be able to use custom MediaItemTracker by specify an url and a media id

Issue

Currently MediaItemTracker are not setup correctly when the input MediaItem has an url and a media id set and the MediaItemTrackerData is set after in a MediaItemSource.

Acceptance criteria

  • CurrentMediaItemTracker start / update / stop tracker when needed.
  • MediaItemTracker.update is called only when data has changed.
  • Tracker are stop and restart if allowed when PillarboxPlayer.replaceMediaItem is called with not the same data.

Tasks

  • Add unit tests to covers all cases.
  • Improve current MediaItem changes detection.
@StaehliJ StaehliJ converted this from a draft issue Feb 8, 2024
@StaehliJ StaehliJ moved this from ✏️ Draft to 📋 Backlog in Pillarbox Feb 8, 2024
@StaehliJ StaehliJ self-assigned this Feb 8, 2024
@StaehliJ StaehliJ moved this from 📋 Backlog to 🚧 In Progress in Pillarbox Feb 8, 2024
@StaehliJ StaehliJ added this to the Test milestone Feb 8, 2024
@MGaetan89 MGaetan89 linked a pull request Feb 12, 2024 that will close this issue
6 tasks
@MGaetan89 MGaetan89 moved this from 🚧 In Progress to 🍿 Code Review in Pillarbox Feb 12, 2024
@MGaetan89 MGaetan89 moved this from 🍿 Code Review to 🚧 In Progress in Pillarbox Feb 12, 2024
@StaehliJ StaehliJ moved this from 🚧 In Progress to 🍿 Code Review in Pillarbox Feb 13, 2024
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
1 participant