Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#12605 - replace Persons involved with Event Participants #12657

Conversation

carina29
Copy link
Contributor

Fixes #12605

@carina29
Copy link
Contributor Author

carina29 commented Oct 17, 2023

This ticket should be merged after Sormas 1.90 was released.

@sormas-vitagroup
Copy link
Contributor

@sormas-vitagroup
Copy link
Contributor

@sormas-vitagroup
Copy link
Contributor

Copy link
Contributor

@MateStrysewske MateStrysewske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changes to all the translation files in the mobile app (except the default values.xml file); the changes should automatically be done by Crowdin, and Android should fall back to the English default if it can't find the translation in the respective language file

@@ -75,7 +75,7 @@ public class Event extends PseudonymizableAdo {
public static final String EVENT_INVESTIGATION_STATUS = "eventInvestigationStatus";
public static final String EVENT_INVESTIGATION_START_DATE = "eventInvestigationStartDate";
public static final String EVENT_INVESTIGATION_END_DATE = "eventInvestigationEndDate";
public static final String EVENT_PERSONS = "eventPersons";
public static final String EVENT_PARTICIPANTS = "eventParticipants";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now inconsistent with the name of the field in the same class; you have to rename that to eventParticipants as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this Event.java class ( from sormas-app/app/src/main/java/de/symeda/sormas/app/backend/event/Event.java) there is no eventPerson or eventParticipant field.

In Event.java from sormas-backend/src/main/java/de/symeda/sormas/backend/event/Event.java we had an eventPersons which I've renamed to eventParticipants or are you reffering to something else? :)

image

@sormas-vitagroup
Copy link
Contributor

1 similar comment
@sormas-vitagroup
Copy link
Contributor

@sormas-vitagroup
Copy link
Contributor

@MateStrysewske MateStrysewske merged commit 7a84a75 into development Oct 24, 2023
10 of 11 checks passed
@MateStrysewske MateStrysewske deleted the #12605-rename_persons_involved_to_event_participants_in_mobile_and_web_apps branch October 24, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename persons involved to event participants in mobile app [1]
3 participants