-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#12605 - replace Persons involved with Event Participants #12657
#12605 - replace Persons involved with Event Participants #12657
Conversation
This ticket should be merged after Sormas 1.90 was released. |
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=12657 |
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=12657 |
…nt_participants_in_mobile_and_web_apps
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=12657 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the changes to all the translation files in the mobile app (except the default values.xml file); the changes should automatically be done by Crowdin, and Android should fall back to the English default if it can't find the translation in the respective language file
@@ -75,7 +75,7 @@ public class Event extends PseudonymizableAdo { | |||
public static final String EVENT_INVESTIGATION_STATUS = "eventInvestigationStatus"; | |||
public static final String EVENT_INVESTIGATION_START_DATE = "eventInvestigationStartDate"; | |||
public static final String EVENT_INVESTIGATION_END_DATE = "eventInvestigationEndDate"; | |||
public static final String EVENT_PERSONS = "eventPersons"; | |||
public static final String EVENT_PARTICIPANTS = "eventParticipants"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now inconsistent with the name of the field in the same class; you have to rename that to eventParticipants as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this Event.java class ( from sormas-app/app/src/main/java/de/symeda/sormas/app/backend/event/Event.java) there is no eventPerson or eventParticipant field.
In Event.java from sormas-backend/src/main/java/de/symeda/sormas/backend/event/Event.java we had an eventPersons which I've renamed to eventParticipants or are you reffering to something else? :)
… string.xml files ( besides the default strings.xml)
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=12657 |
1 similar comment
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=12657 |
…nt_participants_in_mobile_and_web_apps
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=12657 |
Fixes #12605