Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename persons involved to event participants in mobile app [1] #12605

Closed
2 tasks
bernardsilenou opened this issue Oct 4, 2023 · 3 comments · Fixed by #12657
Closed
2 tasks

Rename persons involved to event participants in mobile app [1] #12605

bernardsilenou opened this issue Oct 4, 2023 · 3 comments · Fixed by #12657
Assignees
@carina29 @adinaflorea9
Labels
android-app Affects the Android app change A change of an existing feature (ticket type) events np Adaptations requested by or implemented for Nepal qa-verified Issue has been tested and verified by QA ready Issue fulfills the definition of ready and can be implemented vaadin-app Affects the Vaadin application
Milestone
Iteration 2023-12...

Comments

@bernardsilenou
Copy link

bernardsilenou commented Oct 4, 2023 •
edited by MateStrysewske
Loading

Problem Description

Event participants are called "persons involved "in the mobile app.

Proposed Change

To rename all instances or persons involved to event participants or vice versa.

Added Value/Benefit

Users will not get confused with namings when they use mobile and web apps at the same time

Acceptance Criteria

  • All occurrences of "Person involved" has been renamed to "Event participant"
  • All occurrences of "Persons involved" has been renamed to "Event participants"

Implementation Details

No response

Mockups

No response

Additional Information

No response
@bernardsilenou bernardsilenou added change A change of an existing feature (ticket type) np Adaptations requested by or implemented for Nepal android-app Affects the Android app labels Oct 4, 2023
@bernardsilenou bernardsilenou mentioned this issue Oct 9, 2023
Closed
@MateStrysewske MateStrysewske added ready Issue fulfills the definition of ready and can be implemented vaadin-app Affects the Vaadin application events labels Oct 11, 2023
@carina29 carina29 self-assigned this Oct 13, 2023
@carina29
Copy link
Contributor

carina29 commented Oct 13, 2023 •
edited
Loading

Hello @bernardsilenou, @MateStrysewske :)
I've checked the code and "Persons involved" appears in captions and other places not just for event participants but for event persons too.

We have a distinction in code between event persons and event participants.
image

The "Persons involved" naming should be changed when appears for event persons too or just for event participants?
Thank you very much! :)

carina29 added a commit that referenced this issue Oct 16, 2023
@carina29
#12605 - replace Persons involved with Event Participants
f006bbe
@carina29 carina29 mentioned this issue Oct 17, 2023
Merged
@carina29
Copy link
Contributor

We've agreed with @MateStrysewske that also all the eventPersons occurrences will be renamed to Event Participant in the labels and code.

carina29 added a commit that referenced this issue Oct 17, 2023
@carina29
#12605 - rename parameters with EventPerson to EventParticipant
5735b62
@markusmann-vg markusmann-vg changed the title Rename persons involved to event participants in mobile app Rename persons involved to event participants in mobile app [1] Oct 19, 2023
carina29 added a commit that referenced this issue Oct 19, 2023
@carina29
Merge branch 'development' into #12605-rename_persons_involved_to_eve…
796ac5c 
…nt_participants_in_mobile_and_web_apps
carina29 added a commit that referenced this issue Oct 23, 2023
@carina29
#12605 - rollback the changes from string values ( besides the defaul…
1eeca50 
…t strings.xml)
carina29 added a commit that referenced this issue Oct 23, 2023
@carina29
#12605 - rollback the action_open_event_participant_case changes from…
5e0003c 
… string.xml files ( besides the default strings.xml)
carina29 added a commit that referenced this issue Oct 23, 2023
@carina29
Merge branch 'development' into #12605-rename_persons_involved_to_eve…
4c26d07 
…nt_participants_in_mobile_and_web_apps
MateStrysewske pushed a commit that referenced this issue Oct 24, 2023
@carina29
#12605 - replace Persons involved with Event Participants (#12657)
7a84a75 
* #12605 - replace Persons involved with Event Participants

* #12605 - rename parameters with EventPerson to EventParticipant

* #12605 - rollback the changes from string values ( besides the default strings.xml)

* #12605 - rollback the action_open_event_participant_case changes from string.xml files ( besides the default strings.xml)
@adinaflorea9 adinaflorea9 self-assigned this Oct 24, 2023
@adinaflorea9
Copy link

Verified ticket on the local machine using the latest version of SORMAS from the development branch - 1.91.0-SNAPSHOT(f2aed0d).

@adinaflorea9 adinaflorea9 added the qa-verified Issue has been tested and verified by QA label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carina29 carina29

@adinaflorea9 adinaflorea9

Labels
android-app Affects the Android app change A change of an existing feature (ticket type) events np Adaptations requested by or implemented for Nepal qa-verified Issue has been tested and verified by QA ready Issue fulfills the definition of ready and can be implemented vaadin-app Affects the Vaadin application
Projects
None yet
Milestone
Iteration 2023-12 - 1.91.0
Development

Successfully merging a pull request may close this issue.

#12605 - replace Persons involved with Event Participants SORMAS-Foundation/SORMAS-Project
4 participants
@bernardsilenou @MateStrysewske @carina29 @adinaflorea9