Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trivy and sonar repo scan to GitHub actions [3] #7542

Closed
Tracked by #7503
MartinWahnschaffe opened this issue Dec 17, 2021 · 2 comments · Fixed by #11387, #11388 or #11468
Closed
Tracked by #7503

Add trivy and sonar repo scan to GitHub actions [3] #7542

MartinWahnschaffe opened this issue Dec 17, 2021 · 2 comments · Fixed by #11387, #11388 or #11468
Assignees
Labels
code-quality Reliability, maintainability, reusability, or testability task Something to be done that does not directly affect the software

Comments

@MartinWahnschaffe
Copy link
Contributor

MartinWahnschaffe commented Dec 17, 2021

Problem Description

We are currently using CodeQL to scan for security problems integrated into Github and sonarqube to do a more detailed scan which also includes CVE vulnerabilities. Unfortunately sonarqube is not integrated into the pull request mechanics so it's easy to miss new vulnerabilities.

Proposed Change

  • Use trivy to check for vulnerabilities (most importantly CVE https://avd.aquasec.com/). This should be integrated into the checks executed for pull requests.
  • Include current rules from SonarQube and let these rules evaluate new code in a pull request (for now don't block the pull request).

Acceptance Criteria

  • Warnings for existing problems are shown as security alerts on Github
  • Vulnerabilities in pull requests are shown as part of the checks.

Alternatives

Use sonarcloud: https://sonarcloud.io/github

@MartinWahnschaffe MartinWahnschaffe added technology Technical issues, e.g. synchronization, libraries, plugins, etc. task Something to be done that does not directly affect the software labels Dec 17, 2021
JonasCir added a commit that referenced this issue Dec 22, 2021
JonasCir added a commit that referenced this issue Dec 22, 2021
JonasCir added a commit that referenced this issue Dec 22, 2021
@vidi42 vidi42 added this to the Sprint 110 - 1.67.0 milestone Jan 6, 2022
@StefanKock StefanKock removed this from the Sprint 112 - 1.69.0 milestone Mar 2, 2022
JonasCir added a commit that referenced this issue Jun 28, 2022
JonasCir added a commit that referenced this issue Jun 28, 2022
JonasCir added a commit that referenced this issue Jun 28, 2022
@StefanKock StefanKock added code-quality Reliability, maintainability, reusability, or testability dependencies Pull requests that update a dependency file and removed technology Technical issues, e.g. synchronization, libraries, plugins, etc. labels Jun 30, 2022
@MartinWahnschaffe MartinWahnschaffe added needs-refinement Refinement or further specification required and removed needs-refinement Refinement or further specification required labels Jun 30, 2022
@MartinWahnschaffe MartinWahnschaffe changed the title Add trivy repo scan to GitHub actions Add trivy or sonarcloud repo scan to GitHub actions Oct 11, 2022
@StefanKock StefanKock changed the title Add trivy or sonarcloud repo scan to GitHub actions Add trivy or sonarcloud repo scan to GitHub actions [3] Jan 26, 2023
@StefanKock StefanKock changed the title Add trivy or sonarcloud repo scan to GitHub actions [3] Add trivy and sonarcloud repo scan to GitHub actions [3] Jan 26, 2023
@StefanKock StefanKock changed the title Add trivy and sonarcloud repo scan to GitHub actions [3] Add trivy and sonar repo scan to GitHub actions [3] Jan 26, 2023
@MartinWahnschaffe
Copy link
Contributor Author

To be done:

  • both should not block PRs
  • Add rules from existing sonarcube

@JonasCir
Copy link
Contributor

JonasCir commented Jan 30, 2023

@MartinWahnschaffe Unfortunately, we cannot avoid the CI failing. Once a critical errror is detected in the PR, the corresponding CI pass will fail. You only control the severity level (low, medium, high, critical), but you cannot disable it.

Looking into the existing rules now...

@StefanKock StefanKock added this to the Iteration 2023-01 - 1.80.0 milestone Feb 6, 2023
JonasCir added a commit that referenced this issue Feb 6, 2023
JonasCir added a commit that referenced this issue Feb 6, 2023
JonasCir added a commit that referenced this issue Feb 6, 2023
JonasCir added a commit that referenced this issue Feb 6, 2023
JonasCir added a commit that referenced this issue Feb 6, 2023
JonasCir added a commit that referenced this issue Feb 6, 2023
JonasCir added a commit that referenced this issue Feb 6, 2023
JonasCir added a commit that referenced this issue Feb 6, 2023
@StefanKock StefanKock removed the dependencies Pull requests that update a dependency file label Feb 9, 2023
MartinWahnschaffe added a commit that referenced this issue Feb 9, 2023
…-new

[#7542] only comment on PR event, not on branch push
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality Reliability, maintainability, reusability, or testability task Something to be done that does not directly affect the software
Projects
None yet
4 participants