Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update spring expression dependency to 5.3 #11441

Closed
2 tasks done
MartinWahnschaffe opened this issue Feb 6, 2023 · 0 comments · Fixed by #11432
Closed
2 tasks done

Update spring expression dependency to 5.3 #11441

MartinWahnschaffe opened this issue Feb 6, 2023 · 0 comments · Fixed by #11432
Assignees
@MartinWahnschaffe
Labels
android-app Affects the Android app backend Affects the web backend change A change of an existing feature (ticket type) dependencies Pull requests that update a dependency file
Milestone
Iteration 2023-01...

Comments

@MartinWahnschaffe
Copy link
Contributor

MartinWahnschaffe commented Feb 6, 2023 •
edited
Loading

Problem Description

SpEL is need for campaigns both on server side and android app.
Currently used version has a security issue.
Was not possible to update this, before #10261 was done (min Android 8).

Proposed Change

  • Update to the latest 5 version, which is 5.3.25
  • Add an android unit test to make sure it works on supported android versions

Acceptance Criteria

Implementation Details

Additional Information

Update to version 6 is not possible, because it relies on Java 17 (and Jakarta 9).

Related: #11032 and #7542
@MartinWahnschaffe MartinWahnschaffe added change A change of an existing feature (ticket type) android-app Affects the Android app backend Affects the web backend dependencies Pull requests that update a dependency file labels Feb 6, 2023
@MartinWahnschaffe MartinWahnschaffe self-assigned this Feb 6, 2023
MartinWahnschaffe added a commit that referenced this issue Feb 6, 2023
@MartinWahnschaffe
#11441 update spring expression dependency to get rid of security issue
04854d5 
SpEL is need for campaigns. Added test to make sure needed dependencies are available on Android
@MartinWahnschaffe MartinWahnschaffe mentioned this issue Feb 6, 2023
Merged
MartinWahnschaffe added a commit that referenced this issue Feb 9, 2023
@MartinWahnschaffe
#11441 spring-context ....... 4.3.30.RELEASE -> 5.3.25
d4533e1 
(update spring expression dependency to get rid of security issue)
SpEL is need for campaigns. Added test to make sure needed dependencies are available on Android
MartinWahnschaffe added a commit that referenced this issue Feb 9, 2023
@MartinWahnschaffe
#11441 excluded dependencies to spring-aop and spring-beans
90e496e 
Replaced import of spring utils CollectionUtils with apache commons4
Cleaned up imports of touched files
MartinWahnschaffe added a commit that referenced this issue Feb 9, 2023
@MartinWahnschaffe
Merge pull request #11432 from hzi-braunschweig/11032-spring-expressi…
4fb7468 
…on-dependency

#11441 update spring expression dependency to get rid of security issue
@StefanKock StefanKock mentioned this issue Apr 17, 2023
Closed
8 tasks
@MartinWahnschaffe MartinWahnschaffe mentioned this issue Apr 26, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MartinWahnschaffe MartinWahnschaffe

Labels
android-app Affects the Android app backend Affects the web backend change A change of an existing feature (ticket type) dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
Iteration 2023-01 - 1.80.0
1 participant
@MartinWahnschaffe