-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request: don't require snappy #273
Comments
+1 |
Yes please. This is a huge blocker for my deployment process, as there seems to be no reliable workaround to the referenced issues with snappy. |
+1, snappy requires gyp rebuild, and it will not work on docker node:slim image. |
+1 |
So I found codependency module that will let you do optional modules but I don't have any experience with it and don't how well it works in practice. Is there another way to do this and how do other projects include optional modules? |
I have a solution for this. Hope to get a PR for review soon. |
Historically
kafka-node
requiring snappy has broken quite a few environments and caused many a headache [1].Most users don't require or use compression for these messages, so I would propose not including snappy inside the main module but rather as an optional extension?
[1] See all these issues: #253 #248 #241 #221 #217 #204 #202 #153
The text was updated successfully, but these errors were encountered: