Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: don't require snappy #273

Closed
macobo opened this issue Nov 19, 2015 · 6 comments
Closed

Request: don't require snappy #273

macobo opened this issue Nov 19, 2015 · 6 comments

Comments

@macobo
Copy link

macobo commented Nov 19, 2015

Historically kafka-node requiring snappy has broken quite a few environments and caused many a headache [1].

Most users don't require or use compression for these messages, so I would propose not including snappy inside the main module but rather as an optional extension?

[1] See all these issues: #253 #248 #241 #221 #217 #204 #202 #153

@kaustavha
Copy link

+1
I had a similiar idea since I'm doing some research on Kafka and couldnt get this to compile. Monkey patched this together with my furry paws
https://github.com/kaustavha/kafka-node--light
Still has zlib compression.

@Sneagan
Copy link

Sneagan commented Feb 6, 2016

Yes please. This is a huge blocker for my deployment process, as there seems to be no reliable workaround to the referenced issues with snappy.

@DrMegavolt
Copy link

+1, snappy requires gyp rebuild, and it will not work on docker node:slim image.
This dependency forces to use huge full image node:latest

@milashenko
Copy link

+1

@hyperlink
Copy link
Collaborator

So I found codependency module that will let you do optional modules but I don't have any experience with it and don't how well it works in practice.

Is there another way to do this and how do other projects include optional modules?

@hyperlink
Copy link
Collaborator

I have a solution for this. Hope to get a PR for review soon.

hyperlink added a commit that referenced this issue Apr 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants