Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

does not compile with iojs >= 3.0.0 due to snappy version #241

Closed
jemmyw opened this issue Aug 29, 2015 · 1 comment · Fixed by #246
Closed

does not compile with iojs >= 3.0.0 due to snappy version #241

jemmyw opened this issue Aug 29, 2015 · 1 comment · Fixed by #246

Comments

@jemmyw
Copy link

jemmyw commented Aug 29, 2015

As per #204, iojs-3.0.0 has a newer version of nan, compiling requires snappy version 4.0.0.
@chrishiestand
Copy link
Contributor

+1

chrishiestand added a commit to chrishiestand/kafka-node that referenced this issue Sep 4, 2015
@chrishiestand
upgrade snappy depend to 4.0.0
34650af 
2 snappy unit tests still passing after upgrade

close SOHU-Co#241
@chrishiestand chrishiestand mentioned this issue Sep 4, 2015
Merged
@haio haio closed this as completed in #246 Sep 16, 2015
@macobo macobo mentioned this issue Nov 19, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

upgrade snappy depend to 4.0.0 chrishiestand/kafka-node
2 participants
@jemmyw @chrishiestand