Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quoting of keyTag in QueryToExecute #1888

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Conversation

rkm
Copy link
Member

@rkm rkm commented Jul 29, 2024

Proposed Changes

After #1887.

Uses the appropriate QuerySyntaxHelper to determine the quoted column value.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by the @SMI/Reviewers team

Issues

Fixes #1886

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.96%. Comparing base (50c9536) to head (1061b6c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1888      +/-   ##
==========================================
- Coverage   60.96%   60.96%   -0.01%     
==========================================
  Files         177      177              
  Lines        6559     6558       -1     
  Branches      898      898              
==========================================
- Hits         3999     3998       -1     
  Misses       2289     2289              
  Partials      271      271              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkm rkm requested review from JFriel and a team July 29, 2024 13:57
@rkm rkm enabled auto-merge July 29, 2024 14:01
JFriel
JFriel previously approved these changes Jul 29, 2024
@rkm rkm dismissed JFriel’s stale review July 29, 2024 14:01

The merge-base changed after approval.

JFriel
JFriel previously approved these changes Jul 29, 2024
@rkm rkm disabled auto-merge July 29, 2024 14:05
@rkm rkm enabled auto-merge July 29, 2024 14:06
@rkm rkm dismissed JFriel’s stale review July 29, 2024 14:08

The merge-base changed after approval.

JFriel
JFriel previously approved these changes Jul 29, 2024
@rkm rkm dismissed JFriel’s stale review July 29, 2024 14:10

The merge-base changed after approval.

@rkm rkm force-pushed the fix/query-execute-keytag-quote branch from 956fded to 1061b6c Compare July 29, 2024 14:10
@rkm rkm requested a review from JFriel July 29, 2024 14:10
@rkm rkm merged commit 4d132c3 into main Jul 29, 2024
18 checks passed
@rkm rkm deleted the fix/query-execute-keytag-quote branch July 29, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QueryToExecute does not quote KeyTag in query filter
2 participants