Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QueryToExecute does not quote KeyTag in query filter #1886

Closed
rkm opened this issue Jul 29, 2024 · 0 comments · Fixed by #1888
Closed

QueryToExecute does not quote KeyTag in query filter #1886

rkm opened this issue Jul 29, 2024 · 0 comments · Fixed by #1888
Assignees
@rkm
Labels
type/bug Something isn't working

Comments

@rkm
Copy link
Member

rkm commented Jul 29, 2024

SmiServices/src/microservices/Microservices.CohortExtractor/Execution/RequestFulfillers/QueryToExecute.cs

Lines 40 to 45 in 9d7c11f

public QueryToExecute(QueryToExecuteColumnSet columns, string keyTag)
{
Columns = columns;
KeyTag = keyTag;
Server = columns.Catalogue.GetDistinctLiveDatabaseServer(DataAccessContext.DataExport, false);
}

The KeyTag value needs to be quoted to work with postgres.
@rkm rkm added the type/bug Something isn't working label Jul 29, 2024
@rkm rkm self-assigned this Jul 29, 2024
@rkm rkm mentioned this issue Jul 29, 2024
Merged
11 tasks
@rkm rkm closed this as completed in #1888 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rkm rkm

Labels
type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix quoting of keyTag in QueryToExecute SMI/SmiServices
1 participant
@rkm