App linking #183

grindlock · 2020-05-28T19:50:27Z

Fixes #136

Description

Now to open an app from our all that needs to be done is import the component appLinkingHandler and passed url in the style show under example. A second parameter can be pass named message to show a custom text for the alert. This properly launches an app can pass parameters from our app and can show warnings if the url dont meet the standard from a single component.

A new field, linkedin, has been added in User.js and FormData.js for the user avaible to add their linkedin profile.
In dashboard the urls now reflect the new style and appLinkingHandler replaced Linking.openUrl.
In Profile.js and OtherProfile.js the appLinkingHandler manages the onClick for linkedin and email button.

Types of changes

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Other

Checklist:

My code follows the code style of this project found on Contribution guidelines.
My change requires a change to the documentation.
I have updated the documentation accordingly.

…e profile page. In FormData page at editProfileFormDataRegular added a field call linkedin. In User page under initial state added linkedin field. In the iOS Info.plist added LSApplicationQueriesSchemes array and the whitelisted apps uri.

…style to profile.js. Added the functions to OtherProfile.js to handle app linking there. In FormData.js jus did code clean up to the element added earlier in edit regular profile. ** in profile in form component in the values parameter I erase function that was formating the this.props.activeuser since it was creating a type missmatch in Form.js. the parameter values is expecting an object but was receiving an array. this cause the app to crash when onsubmit was called.**

…s to FormData are included here.

HanielDiaz

Overall looks like it's going in the right direction. Just 1 section with alot of complexity and a few small details to improve readability.

The reason why I'm so anal about readability is because code is read way more often than it is written, spending a lot of time and effort into writing readable code always pays off down the line when other people need to read and make changes to the code. According to many sources we spend 10 times more time reading code than we do writing it.

ios/Pods/Local Podspecs/React-DevSupport.podspec.json

ios/shpeucfapp/Info.plist

src/screens/General/Dashboard.js

src/utils/appLinking.js

esteban737

Just some brief changes to the appLinkingHandler documentation. Also as previously requested we can probably work to simplify the code so it's easier to understand and work with. Some JSDocs could also go a long way

src/utils/appLinking.js

esteban737

Sorry for the additional pr review, but after testing the slack button link isn't working and is getting an unhandled promise rejection and there is error obtained when editing our profiles. You're going to want to merge the newest commits into your fork.

ios/Pods/QBImagePickerController/QBImagePicker/QBAlbumCell.h

src/screens/General/Dashboard.js

HanielDiaz · 2020-06-04T17:52:49Z

src/screens/User/OtherProfile.js

@@ -147,15 +148,21 @@ class OtherProfile extends Component {
 			socialmediarow
 		} = styles;

+		const {


src/screens/User/Profile.js

ios/Pods/Local Podspecs/React-DevSupport.podspec.json

ios/shpeucfapp/Info.plist

src/utils/appLinking.js

idelmr

Indentation, documentation, typos, and some minor recommendations - please mark these as resolved to know what was fixed.

src/screens/User/OtherProfile.js

src/utils/appLinking.js

…e profile page. In FormData page at editProfileFormDataRegular added a field call linkedin. In User page under initial state added linkedin field. In the iOS Info.plist added LSApplicationQueriesSchemes array and the whitelisted apps uri.

…style to profile.js. Added the functions to OtherProfile.js to handle app linking there. In FormData.js jus did code clean up to the element added earlier in edit regular profile. ** in profile in form component in the values parameter I erase function that was formating the this.props.activeuser since it was creating a type missmatch in Form.js. the parameter values is expecting an object but was receiving an array. this cause the app to crash when onsubmit was called.**

…s to FormData are included here.

HanielDiaz · 2020-07-01T16:26:14Z

src/screens/User/OtherProfile.js

@@ -147,15 +148,21 @@ class OtherProfile extends Component {
 			socialmediarow
 		} = styles;

+		const {


bumpidump dump

src/utils/appLinking.js

idelmr

Reshaping final changes to the pull request

src/components/general/FilterList.js

src/data/FormData.js

src/screens/General/Dashboard.js

src/screens/User/OtherProfile.js

src/utils/appLinking.js

idelmr

Almost there...

src/utils/appLinking.js

idelmr

Confused about where you're storing the data for slackinfo, is it yaml or env? There might be some conflict
Minor enhancements

idelmr · 2020-08-06T08:49:49Z

src/assets/Yaml/slackInfo.yml

+channel:
+  general: CPRDXHHD4
+  announcements: CC5S86GHE
+  fundraisingCommittee: CCUUWRU1Y
+  motorshpe: CP5HC76TD
+  projects: CNATZRD9C
+  shpejr: GCWFE5630
+  mentorshpe: C016KGD2WHH
+  computereng: GN4U8FPDK
+  projectleads: GNBH9T4UC


computereng is a private channel

unsure about projectleads and shpejr

I put them there in case the committees wanted to link to slack. Should I take them off?

I think it's fine, but (1) people won't find a private channel if they're not in it and (2) we don't have all of the private channel codes, so there are a couple missing. Moreover computereng isn't a committee and I'm afraid SHPE will keep changing channels, so it would be safer to only have the default ones.

src/utils/appLinking.js

Committing Idel suggestion. Co-authored-by: Idel <[email protected]>

Conference screen

Revert "Conference screen"

idelmr

I would want to test and change some minor details, but I understand you're extremely busy. I think we can push this now and change stuff later

idelmr · 2021-02-19T06:12:55Z

Moved to branch appLinking

Sergio Perez-Aponte added 4 commits May 21, 2020 04:50

Reinstalled pods

731d4cb

Rewrote openApp and openEmail into one component. Also, Haniel change…

6b3a728

…s to FormData are included here.

HanielDiaz requested review from idelmr, HanielDiaz and esteban737 May 28, 2020 23:52

HanielDiaz requested changes May 29, 2020

View reviewed changes

esteban737 requested changes May 29, 2020

View reviewed changes

src/utils/appLinking.js Outdated Show resolved Hide resolved

src/utils/appLinking.js Show resolved Hide resolved

src/utils/appLinking.js Outdated Show resolved Hide resolved

src/utils/appLinking.js Show resolved Hide resolved

esteban737 requested changes May 29, 2020

View reviewed changes

Sergio Perez-Aponte added 3 commits June 3, 2020 04:13

re-write of app linking.

82eb1f3

rename in dashboard the buttonlinks to socialmedialink.

6cba53b

resolving merge

03d6a23

grindlock requested review from HanielDiaz and esteban737 June 5, 2020 08:52

grindlock marked this pull request as draft June 5, 2020 08:53

HanielDiaz requested changes Jun 5, 2020

View reviewed changes

idelmr suggested changes Jun 6, 2020

View reviewed changes

idelmr assigned grindlock Jun 6, 2020

idelmr added the build label Jun 6, 2020

idelmr reviewed Jun 7, 2020

View reviewed changes

src/utils/appLinking.js Outdated Show resolved Hide resolved

grindlock force-pushed the master branch from 38dca53 to 3054a24 Compare June 7, 2020 08:48

Sergio Perez-Aponte and others added 7 commits June 7, 2020 04:59

Rewrote openApp and openEmail into one component. Also, Haniel change…

acfd80d

…s to FormData are included here.

re-write of app linking.

4edf270

Update appLinking.js

038d3f2

Fix filterlist initial value bug

5d2dc8d

rename in dashboard the buttonlinks to socialmedialink.

280a84f

grindlock force-pushed the master branch from 3054a24 to 280a84f Compare June 7, 2020 09:00

grindlock requested review from idelmr and HanielDiaz July 1, 2020 10:28

HanielDiaz requested changes Jul 1, 2020

View reviewed changes

idelmr suggested changes Jul 2, 2020

View reviewed changes

Latest fixes to the app linking component.

ea01d8f

idelmr requested review from HanielDiaz and idelmr July 4, 2020 04:49

HanielDiaz approved these changes Jul 5, 2020

View reviewed changes

idelmr requested a review from HanielDiaz July 5, 2020 19:42

idelmr suggested changes Jul 5, 2020

View reviewed changes

src/utils/appLinking.js Outdated Show resolved Hide resolved

src/utils/appLinking.js Outdated Show resolved Hide resolved

src/utils/appLinking.js Show resolved Hide resolved

src/utils/appLinking.js Outdated Show resolved Hide resolved

Sergio Perez-Aponte added 6 commits July 6, 2020 14:44

move slackinfo to env and do some cleaning.

88aaeb0

one last time. channel IDs are in the env file

a19ea9f

miss something

1ee6baa

working with section list in the conference page.

4853298

Added the conference to the router and more page.

c32170b

Conference page is finish.

d56dd32

idelmr suggested changes Aug 6, 2020

View reviewed changes

grindlock and others added 8 commits August 29, 2020 22:47

Update src/utils/appLinking.js

b20b2de

Committing Idel suggestion. Co-authored-by: Idel <[email protected]>

h

c074446

Committing the changes resqueted.

85e7b76

resolving a merge conflict.

448573e

Merge branch 'master' into conferenceScreen

af8326d

Merge pull request #1 from grindlock/conferenceScreen

a61597b

Conference screen

Revert "Conference screen"

607b4c5

Merge pull request #2 from grindlock/revert-1-conferenceScreen

721c8b4

Revert "Conference screen"

idelmr suggested changes Dec 17, 2020

View reviewed changes

idelmr changed the base branch from master to appLinking February 19, 2021 06:05

idelmr closed this Feb 19, 2021

idelmr deleted the branch SHPEUCF:appLinking February 19, 2021 06:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

App linking #183

App linking #183

grindlock commented May 28, 2020 •

edited by idelmr

Loading

HanielDiaz left a comment •

edited

Loading

esteban737 left a comment

esteban737 left a comment

HanielDiaz Jun 4, 2020

idelmr left a comment

HanielDiaz Jul 1, 2020

idelmr left a comment

idelmr left a comment

idelmr left a comment

idelmr Aug 6, 2020

grindlock Aug 30, 2020

idelmr Aug 30, 2020

idelmr left a comment

idelmr commented Feb 19, 2021

App linking #183

App linking #183

Conversation

grindlock commented May 28, 2020 • edited by idelmr Loading

Description

Types of changes

Checklist:

HanielDiaz left a comment • edited Loading

Choose a reason for hiding this comment

esteban737 left a comment

Choose a reason for hiding this comment

esteban737 left a comment

Choose a reason for hiding this comment

HanielDiaz Jun 4, 2020

Choose a reason for hiding this comment

idelmr left a comment

Choose a reason for hiding this comment

HanielDiaz Jul 1, 2020

Choose a reason for hiding this comment

idelmr left a comment

Choose a reason for hiding this comment

idelmr left a comment

Choose a reason for hiding this comment

idelmr left a comment

Choose a reason for hiding this comment

idelmr Aug 6, 2020

Choose a reason for hiding this comment

grindlock Aug 30, 2020

Choose a reason for hiding this comment

idelmr Aug 30, 2020

Choose a reason for hiding this comment

idelmr left a comment

Choose a reason for hiding this comment

idelmr commented Feb 19, 2021

grindlock commented May 28, 2020 •

edited by idelmr

Loading

HanielDiaz left a comment •

edited

Loading