Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open links in corresponding app #136

Open
idelmr opened this issue Apr 7, 2020 · 1 comment
Open

Open links in corresponding app #136

idelmr opened this issue Apr 7, 2020 · 1 comment

Comments

@idelmr
Copy link
Contributor

idelmr commented Apr 7, 2020

Describe the feature

Links for Slack, Facebook, Instagram, and Email should be opened in the phone's app, if there is one. In case there isn't, a link to a browser should be opened as usual.

Describe possible solutions considered

The Linking component will be used for this and it can be done directly if we have the link to open up the app (it's usually something not straightforward). These links can be found on deeplink.me (use the WayBack Machine if broken) or on Google DuckDuckGo with a bit of research.

// Example for the SHPE Slack workspace
Linking.openURL(slack://open?team=TC61JSPUZ)

Additional comments

This should be simple, but the problem resides in Linking.canOpenURL, to check if the user's phone has the app to open it. Without checking if it can open it, the deep link will not do anything (or may even break the app). With Android, it's done pretty straightforward, but iOS is another story, since you need to add some keys into files and do additional changes.

Some stuff that may be helpful...

shpeucfapp/ios/shpeucfapp/Info.plist is the iOS file that contains the following array.

key in "LSApplicationQueriesSchemes" array

grindlock pushed a commit to grindlock/shpeucfapp that referenced this issue May 22, 2020
…style to profile.js. Added the functions to OtherProfile.js to handle app linking there. In FormData.js jus did code clean up to the element added earlier in edit regular profile. ** in profile in form component in the values parameter I erase function that was formating the this.props.activeuser since it was creating a type missmatch in Form.js. the parameter values is expecting an object but was receiving an array. this cause the app to crash when onsubmit was called.**
This was referenced May 26, 2020
grindlock pushed a commit to grindlock/shpeucfapp that referenced this issue Jun 7, 2020
…style to profile.js. Added the functions to OtherProfile.js to handle app linking there. In FormData.js jus did code clean up to the element added earlier in edit regular profile. ** in profile in form component in the values parameter I erase function that was formating the this.props.activeuser since it was creating a type missmatch in Form.js. the parameter values is expecting an object but was receiving an array. this cause the app to crash when onsubmit was called.**
@idelmr
Copy link
Contributor Author

idelmr commented Feb 22, 2021

Continued on appLinking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant