feat: DAIDE parser for any pattern and automatic validation #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parser can now parse not just messages and arrangements, but any DAIDE pattern. Keyword objects are now automatically validate upon instantiation Closes: #36
The issue was that there was no `visit_sub_arrangement` method, so that was being treated as generic visit.
Closed
byung-o
reviewed
Nov 28, 2022
mjspeck
commented
Nov 28, 2022
mjspeck
commented
Nov 28, 2022
mjspeck
commented
Nov 28, 2022
mjspeck
commented
Nov 28, 2022
mjspeck
commented
Nov 28, 2022
byung-o
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser can now parse not just messages and arrangements, but any
DAIDE pattern.
Keyword objects are now automatically validated upon instantiation.
Closes: #36, #29