Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Testing to PR #29

Closed
mjspeck opened this issue Nov 2, 2022 · 0 comments · Fixed by #37
Closed

Add Testing to PR #29

mjspeck opened this issue Nov 2, 2022 · 0 comments · Fixed by #37
Assignees
@mjspeck

Comments

@mjspeck
Copy link
Collaborator

mjspeck commented Nov 2, 2022

We should test that code, commits, docstrings, etc. follow the appropriate formatting whenever a PR is submitted.
@mjspeck mjspeck self-assigned this Nov 2, 2022
@mjspeck mjspeck mentioned this issue Nov 23, 2022
Merged
@mjspeck mjspeck linked a pull request Nov 28, 2022 that will close this issue
feat: DAIDE parser for any pattern and automatic validation #37
Merged
mjspeck added a commit that referenced this issue Nov 28, 2022
@mjspeck
feat: DAIDE parser for any pattern and automatic validation (#37)
a0d016e 
feat: daide parser for any pattern and automatic validation

The parser can now parse not just messages and arrangements, but any
DAIDE pattern.

Keyword objects are now automatically validated upon instantiation.

Closes: #36, #29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjspeck mjspeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: DAIDE parser for any pattern and automatic validation SHADE-AI/daidepp
1 participant
@mjspeck