Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParseConfig doesn't understand -Wl flags. #1

Closed
wants to merge 1 commit into from

Conversation

merlin66
Copy link
Contributor

@merlin66 merlin66 commented Sep 25, 2017

This issue was originally created at: 2004-05-03 01:46:30.
This issue was reported by: noselasd.
noselasd said at 2004-05-03 01:46:30

This has annoyed me abit. ParseConfig(..) is nice to parse output of
xxx-config programs and pkg-config. However ParseConfig doesn't understand
the -Wl flag. Which means 'pass flag to linker'. It ends up in the CPPDEFINES
as far as I can see.
Thus on a machine here, every pkg-config --libs will have among others
'-Wl,-R/usr/pkg/lib' . And as ParseConfig places that in the CPPDEFINES, it
should go to LINKFLAGS I guess. I get a warning on compiling every .c file that
linking isn't done, and linking might fail since it actually doesn't get all
link flags.
I guess this goes for other -Wl flags as well, afaik ther's -Wsomething to pass
flags to the assembler and preprocessor as well.

stevenknight said at 2004-05-03 07:01:11

Fix has been checked in for next release. Thanks!

stevenknight said at 2006-01-05 18:14:20

Changing version to "unspecified" to conform to new scheme.

kmaples said at 2006-05-20 17:03:30

making the default milestone consistent across the project

kmaples said at 2006-05-20 17:14:13

making the version consistent across the project

@bdbaddog
Copy link
Contributor

I think the tests can be fixed without the future. The issue is this:

print("VARIABLE =", repr(env['VARIABLE']))
#   the comma above makes it a tuple that's being printed under py 2.7

@merlin66
Copy link
Contributor Author

merlin66 commented Sep 25, 2017

Would this variant using + be ok?
print("VARIABLE =" + repr(env['VARIABLE']))

I've got a bunch of edits to redo this, mainly +, but in some cases (where value is not string, I switched to %s"% I'm going to decline this and push mine.

@bdbaddog bdbaddog closed this Sep 25, 2017
@bdbaddog
Copy link
Contributor

See: #2

@merlin66
Copy link
Contributor Author

Ok, thanks, then I will let you handle it, just let me know if there's something I should fix.

@bdbaddog bdbaddog changed the title Fix test failures introduced when print_function import was removed ParseConfig doesn't understand -Wl flags. Jan 2, 2018
mwichmann referenced this pull request in mwichmann/scons Feb 6, 2019
The wix tool uses the WiX Toolset for msi packaging.  It isn't
working, and is never run by scons' CI infrastructure so the problems
are not reported.

Add some code for better findability.

Problem #1: a language setting is required, and none of the tests do so.

Signed-off-by: Mats Wichmann <[email protected]>
@mwichmann mwichmann mentioned this pull request Feb 6, 2019
3 tasks
mwichmann referenced this pull request in mwichmann/scons Feb 9, 2019
The wix tool uses the WiX Toolset for msi packaging.  It isn't
working, and is never run by scons' CI infrastructure so the problems
are not reported.

Add some code for better findability.

Problem #1: a language setting is required, and none of the tests do so.

Signed-off-by: Mats Wichmann <[email protected]>
bdbaddog pushed a commit that referenced this pull request Apr 23, 2019
changes to unit test to avoid hitting the filesystem
bdbaddog pushed a commit that referenced this pull request Feb 21, 2020
This change adds support for scanning multiple entries in an action string in
order to better support the following use cases:

1. A file is provided in an action string and should be taken as a dependency.
   For example, an action string "$PERL somefile.pl".
2. An action string actually has two actions separated by &&. For example,
   "cd <some_dir> && $ZIP <args>".

Adding support for #1 actually allows us to fix the test
IMPLICIT_COMMAND_DEPENDENCIES.py on Windows, which was previously treating a
Python file as executable even on Windows. This was causing tests to repeatedly
open the default handler of Python files, which if set to Visual Studio causes
DDE hangs. This test is fixed because now we can have the action string specify
python as the first command and still take an implicit dependency on the
script, which is now the second command.
bdbaddog pushed a commit that referenced this pull request Oct 13, 2020
The way runtest.py passes the list of fixture directories is racy because it
sets it in os.environ['FIXTURE_DIRS'] and then spawns the subprocess, counting
on Python to start the subprocess before that list is overwritten when spawning
the next directory. At least on Windows, the environment is not copied in
subprocess.run so runtest.py may overwrite the list of fixture directories
with the list for test #2 while the subprocess module is still kicking off
test #1. I was able to easily reproduce this by running the command:
`python runtest.py -j 2 test\MSVC\VSWHERE.py test\AS\ASPPFLAGS.py`
a few times in a row. However, with this fix, that command repeatedly succeeds.

To validate ths fix, I also ran that command with "--xml a.xml" and
"--xml a.xml --nopipefiles" to validate that those other executors worked
correctly.
bdbaddog pushed a commit that referenced this pull request Apr 12, 2021
bdbaddog pushed a commit that referenced this pull request Jun 21, 2023
@bdbaddog bdbaddog mentioned this pull request Oct 4, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants