-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ParseConfig doesn't understand -Wl flags. #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the tests can be fixed without the future. The issue is this:
|
Would this variant using + be ok? I've got a bunch of edits to redo this, mainly +, but in some cases (where value is not string, I switched to %s"% I'm going to decline this and push mine. |
See: #2 |
Ok, thanks, then I will let you handle it, just let me know if there's something I should fix. |
bdbaddog
changed the title
Fix test failures introduced when print_function import was removed
ParseConfig doesn't understand -Wl flags.
Jan 2, 2018
This was referenced Jan 2, 2018
Closed
Closed
This was referenced Jan 2, 2018
mwichmann
referenced
this pull request
in mwichmann/scons
Feb 6, 2019
The wix tool uses the WiX Toolset for msi packaging. It isn't working, and is never run by scons' CI infrastructure so the problems are not reported. Add some code for better findability. Problem #1: a language setting is required, and none of the tests do so. Signed-off-by: Mats Wichmann <[email protected]>
3 tasks
mwichmann
referenced
this pull request
in mwichmann/scons
Feb 9, 2019
The wix tool uses the WiX Toolset for msi packaging. It isn't working, and is never run by scons' CI infrastructure so the problems are not reported. Add some code for better findability. Problem #1: a language setting is required, and none of the tests do so. Signed-off-by: Mats Wichmann <[email protected]>
bdbaddog
pushed a commit
that referenced
this pull request
Apr 23, 2019
changes to unit test to avoid hitting the filesystem
3 tasks
bdbaddog
pushed a commit
that referenced
this pull request
Feb 21, 2020
This change adds support for scanning multiple entries in an action string in order to better support the following use cases: 1. A file is provided in an action string and should be taken as a dependency. For example, an action string "$PERL somefile.pl". 2. An action string actually has two actions separated by &&. For example, "cd <some_dir> && $ZIP <args>". Adding support for #1 actually allows us to fix the test IMPLICIT_COMMAND_DEPENDENCIES.py on Windows, which was previously treating a Python file as executable even on Windows. This was causing tests to repeatedly open the default handler of Python files, which if set to Visual Studio causes DDE hangs. This test is fixed because now we can have the action string specify python as the first command and still take an implicit dependency on the script, which is now the second command.
3 tasks
bdbaddog
pushed a commit
that referenced
this pull request
Oct 13, 2020
The way runtest.py passes the list of fixture directories is racy because it sets it in os.environ['FIXTURE_DIRS'] and then spawns the subprocess, counting on Python to start the subprocess before that list is overwritten when spawning the next directory. At least on Windows, the environment is not copied in subprocess.run so runtest.py may overwrite the list of fixture directories with the list for test #2 while the subprocess module is still kicking off test #1. I was able to easily reproduce this by running the command: `python runtest.py -j 2 test\MSVC\VSWHERE.py test\AS\ASPPFLAGS.py` a few times in a row. However, with this fix, that command repeatedly succeeds. To validate ths fix, I also ran that command with "--xml a.xml" and "--xml a.xml --nopipefiles" to validate that those other executors worked correctly.
3 tasks
3 tasks
bdbaddog
pushed a commit
that referenced
this pull request
Apr 12, 2021
Slight reorg of setting default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was originally created at: 2004-05-03 01:46:30.
This issue was reported by:
noselasd
.noselasd said at 2004-05-03 01:46:30
stevenknight said at 2004-05-03 07:01:11
stevenknight said at 2006-01-05 18:14:20
kmaples said at 2006-05-20 17:03:30
kmaples said at 2006-05-20 17:14:13