changes to unit test to avoid hitting the filesystem #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwichmann
reviewed
Apr 22, 2019
| @@ -322,12 +361,12 @@ def parseToken(self, token): | |||
| # 'Foo$1Inner' | |||
| # https://github.com/SCons/scons/issues/2087 | |||
| if self.outer_state.localClasses and \ | |||
| self.outer_state.stackBrackets[-1] > \ | |||
| self.outer_state.stackBrackets[-2]+1: | |||
| self.outer_state.stackBrackets[-1] > \ | |||
There was a problem hiding this comment.
maybe parens here to group the "a > b" part would make it more readable? and eliminate the need for that backslash-line-continuation
There was a problem hiding this comment.
What does pylint think of such? ;)
There was a problem hiding this comment.
No particular reaction one way or the other. . Has plenty of other things to say, though... included just for grins:
mwichmann
approved these changes
Apr 22, 2019
bdbaddog
pushed a commit
that referenced
this pull request
Feb 21, 2020
This change adds support for scanning multiple entries in an action string in order to better support the following use cases: 1. A file is provided in an action string and should be taken as a dependency. For example, an action string "$PERL somefile.pl". 2. An action string actually has two actions separated by &&. For example, "cd <some_dir> && $ZIP <args>". Adding support for #1 actually allows us to fix the test IMPLICIT_COMMAND_DEPENDENCIES.py on Windows, which was previously treating a Python file as executable even on Windows. This was causing tests to repeatedly open the default handler of Python files, which if set to Visual Studio causes DDE hangs. This test is fixed because now we can have the action string specify python as the first command and still take an implicit dependency on the script, which is now the second command.
mwichmann
pushed a commit
that referenced
this pull request
Oct 14, 2020
The way runtest.py passes the list of fixture directories is racy because it sets it in os.environ['FIXTURE_DIRS'] and then spawns the subprocess, counting on Python to start the subprocess before that list is overwritten when spawning the next directory. At least on Windows, the environment is not copied in subprocess.run so runtest.py may overwrite the list of fixture directories with the list for test #2 while the subprocess module is still kicking off test #1. I was able to easily reproduce this by running the command: `python runtest.py -j 2 test\MSVC\VSWHERE.py test\AS\ASPPFLAGS.py` a few times in a row. However, with this fix, that command repeatedly succeeds. To validate ths fix, I also ran that command with "--xml a.xml" and "--xml a.xml --nopipefiles" to validate that those other executors worked correctly.
mwichmann
pushed a commit
that referenced
this pull request
Apr 13, 2021
Slight reorg of setting default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.