added sbnd recomb and diffusion fcls #366
Conversation
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v09_75_02 SBNSoftware/sbncode@v09_75_02 SBNSoftware/sbnanaobj@v09_21_02 SBNSoftware/sbnobj@v09_17_03 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
✔️ CI build for SBND Succeeded on slf7 for e20:prof -- details available through the CI dashboard parent CI build details are available through the CI dashboard |
|
@sjgardiner @jzennamo @cerati can you have a look/sign the PR? |
|
As discussed with @fjnicolas offline. This is a potentially temporary update to this PR. Decision on wirecell inclusion are still being made and so further updates may be needed this afternoon. |
- adds a detsim fcl that **turns off** 1d tpc sim, and only runs crt+pds sim - adds a reco1 fcl that takes wc 2d sim as input
|
Just added two fcls that:
|
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v09_75_02 SBNSoftware/sbncode@v09_75_02 SBNSoftware/sbnanaobj@v09_21_02 SBNSoftware/sbnobj@v09_17_03 |
|
✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
There was a problem hiding this comment.
Following conversations and offline tests with @lynnt-uchicago @ibsafa and others we're happy that this PR is ready to go and by extension everything needed for the release is in place!
| outputCommands: [ "keep *_*_*_*" | ||
| # Drop the SimEnergyDeposits made by LArG4 | ||
| , "drop sim::SimEnergyDeposits_largeant_*_*" | ||
| # Drop the IonAndScint w/ SCE offsets applied | ||
| , "drop *_ionandscint__*" | ||
| # Drop LArG4 AuxDetHits, now replaced by AuxDetSimChannels | ||
| , "drop sim::AuxDetHits_*_*_*" | ||
| ] |
There was a problem hiding this comment.
Hi! Sorry I saw this PR was merged already, but I just noticed that this PR changes the standard g4 fcl. Is this intentional? This way, it's keeping all data products, with many copies of SimEnergyDeposits. @fjnicolas @lynnt-uchicago @henrylay97
There was a problem hiding this comment.
hi! yes, the reason is that g4_drops.fcl was created for the lite version. it was decided that sim energy deposits would be dropped as part of the lite workflow but should be available by default since a few people have needed those sim energy deposits recently
There was a problem hiding this comment.
Thanks for clarifying @ibsafa! LArG4 makes three copies of SimEnergyDeposits, two of them can be dropped without loss (but people can correct me!). The reason why all three were dropped was a mistake, and was fixed by @fjnicolas with PR #368. My suggestion would be to keep that block above in the standard fcl, and add more drops commands in the g4_drops.fcl for production purposes.
There was a problem hiding this comment.
@marcodeltutto thanks for the suggestion! A conservative solution was finally adopted prioritizing having a working tag for the workshop production. I also agree we are probably keeping "to much" with the current solution and we will revisit it after the workshop. In any case, we think a major refactoring of the fhicls is really needed at this point. I'm opening a issue to keep track of it! #374
There was a problem hiding this comment.
Sounds good @fjnicolas, thanks! I agree a refactoring is really needed
No description provided.