Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert bin scripts to entry points #109

Merged
merged 16 commits into from
Feb 21, 2024
Merged

Convert bin scripts to entry points #109

merged 16 commits into from
Feb 21, 2024

Conversation

sroet
Copy link
Collaborator

@sroet sroet commented Feb 15, 2024 •
edited
Loading

closes #5, also allows for direct calling these functions with a given argv which should help testing

TODO:

  • make entry points file
  • check for double imports and move them to the top
  • move actual plotting code to its own file instead of bin script
  • format the new files with ruff and black
  • update pypoject.toml to install the new entry points as bin scripts
  • remove old bin directory
  • add tests that these scripts are installed and on the PATH
  • add tests that these entry points can be called with a -h flag
  • make sure code is still importable if matplotlib is not installed

@sroet sroet marked this pull request as ready for review February 20, 2024 17:22
@sroet sroet requested a review from McHaillet February 20, 2024 17:22
@sroet
Copy link
Collaborator Author

sroet commented Feb 20, 2024

@McHaillet should this lead to an increase in version number? (this does technically add a bunch of functionality due to the plotting.py file)

McHaillet
McHaillet approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@McHaillet McHaillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just noticed this line that looks like it can be removed now. A version bump also seems like a good idea.

src/pytom_tm/entry_points.py Outdated Show resolved Hide resolved
@sroet sroet merged commit 0c920fa into SBC-Utrecht:main Feb 21, 2024
@sroet sroet deleted the convert_to_entry_points branch February 21, 2024 11:28
@McHaillet McHaillet mentioned this pull request Feb 21, 2024
Closed
sroet added a commit that referenced this pull request Feb 29, 2024
@sroet
Update main branch version to 0.3.6
b3b003f 
The release of last week 0.3.5 was done on a version of the code that did not have the correct version number. So when I updated it in #109 it was still one too few
@sroet sroet mentioned this pull request Feb 29, 2024
Merged
sroet added a commit that referenced this pull request Feb 29, 2024
@sroet
Update main branch version to 0.4.0 (#133)
12bcd1f 
* Update main branch version to 0.3.6

The release of last week 0.3.5 was done on a version of the code that did not have the correct version number. So when I updated it in #109 it was still one too few

* Update pyproject.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McHaillet McHaillet McHaillet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

switch to entry points instead of bin scripts
2 participants
@sroet @McHaillet