Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-li-notification-group): align priority icon #2584

Merged
merged 3 commits into from
Jan 12, 2021
Merged

fix(ui5-li-notification-group): align priority icon #2584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5810040
fix(ui5-li-notification-group): align prio icon
ilhan007 Dec 16, 2020
91ba833
Merge branch 'main' into fix-notification-prio-alignment
ilhan007 Jan 11, 2021
002d46c
small fix
ilhan007 Jan 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/fiori/src/NotificationListItem.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
</div>

<div class="ui5-nli-content {{classes.content}}">
<div class="ui5-nli-heading">
<div class="ui5-nli-heading-wrapper">
{{#if hasPriority}}
<ui5-icon
class="ui5-prio-icon ui5-prio-icon--{{priorityIcon}}"
Expand Down
4 changes: 4 additions & 0 deletions packages/fiori/src/NotificationListItem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ const metadata = {
*
* <br><br>
* <b>Note:</b> Consider using the <code>ui5-avatar</code> to display icons, initials or images.
* <br>
* <b>Note:</b>In order to be complaint with the UX guidlines and for best experience,
* we recommend using avatars with 2rem X 2rem in size (32px X 32px). In case you are using the <code>ui5-avatar</code>
* you can set its <code>size</code><code> property to <code>XS</code> to get the required size - <code><ui5-avatar size="XS"></code>.
*
* @type {HTMLElement}
* @slot
Expand Down
2 changes: 1 addition & 1 deletion packages/fiori/src/themes/NotificationListGroupItem.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
}

.ui5-nli-group-toggle-btn {
margin-right: 1rem;
margin-right: 0.75rem;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

margin-right: 1.25rem;
margin-left: 0.5rem;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback, Teo.

Just to clarify, in openui5 the toggle button has margin-right: 0.75rem

.sapMNLGroupCollapseButton {
       margin-right: 0.75rem;
       min-width: 2.25rem;
       max-width: 2.25rem;
}

When I apply margin-right: 0.75 rem the result is: (seems aligned to me)
Screenshot 2020-12-18 at 5 16 54 PM

When I apply margin-right: 1.25rem; and margin-left: 0.5rem; the result is (not quite aligned):
Screenshot 2020-12-18 at 5 24 52 PM

cursor: pointer;
}

Expand Down
5 changes: 5 additions & 0 deletions packages/fiori/src/themes/NotificationListItem.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,11 @@
box-sizing: border-box;
}

.ui5-nli-heading-wrapper {
display: flex;
flex-direction: row;
}

.ui5-nli-heading {
display: flex;
margin-bottom: 0.25rem;
Expand Down