fix(ui5-li-notification-group): align priority icon #2584
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The avatar slot give users the freedom to add their own images, icons or to use the available ui5-avatar web component. We don't want to restrict the size of the avatar internally, so whenever the users set ui5-avatar size="XS", ui5-avatar size="M", ui5-avatar size="XL".. they get what they expect.
However, we explain that for best experience we recommend using images/avatars 32px X 32px. With this size, the priority icons are perfectly aligned across the NotificationListGroupItem and its children - NotificationLisItem(s).
In all our test pages and playground samples we use the ui5-avatar with size="XS", which results in 32px X 32px, but it turns out a degradation has been introduced and the XS size of the ui5-avatar appears bigger than expected. For that, there is a PR #2582 already merged.
Now the alignment with a custom image 32px X 32px or ui5-avatar with size="XS" will look like on the image below:
Prerequisite: #2582 (merged already)
Change: adjust the margin of the NotificationListGroupItem's expand/collapse button to align the priority icon
and document the recommended avatar size.