Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-side-navigation): remove inappropriate exclamation mark usage #10769

Merged
merged 1 commit into from
Feb 10, 2025
Merged

fix(ui5-side-navigation): remove inappropriate exclamation mark usage #10769

merged 1 commit into from
Feb 10, 2025

Conversation

LidiyaGeorgieva
Copy link
Contributor

fixes: #10714

@LidiyaGeorgieva LidiyaGeorgieva merged commit 469cc9d into main Feb 10, 2025
12 checks passed
@LidiyaGeorgieva LidiyaGeorgieva deleted the ui5-side-navigation-checks branch February 10, 2025 15:12
dobromiraboycheva added a commit that referenced this pull request Feb 11, 2025
@dobromiraboycheva
Merge branch 'main' of https://github.com/SAP/ui5-webcomponents into …
06942af 
…ui5-user-menu-tests

* 'main' of https://github.com/SAP/ui5-webcomponents:
  refactor(ui5-multi-combobox): switch to .tsx (#10807)
  refactor(ListItem): delete unused code (#10796)
  chore(deps-dev): bump esbuild from 0.19.9 to 0.25.0 (#10816)
  chore(deps-dev): bump vitest from 3.0.2 to 3.0.5 (#10785)
  test: add command for single cy test run (#10813)
  docs: fix TimelineGrowingMode enum docs (#10815)
  fix(ui5-side-navigation): remove inappropriate exclamation mark usage (#10769)
dobromiraboycheva added a commit that referenced this pull request Feb 11, 2025
@dobromiraboycheva
Merge branch 'main' of https://github.com/SAP/ui5-webcomponents into …
cf8e3bd 
…ui5-settings

* 'main' of https://github.com/SAP/ui5-webcomponents:
  refactor(ui5-multi-combobox): switch to .tsx (#10807)
  refactor(ListItem): delete unused code (#10796)
  chore(deps-dev): bump esbuild from 0.19.9 to 0.25.0 (#10816)
  chore(deps-dev): bump vitest from 3.0.2 to 3.0.5 (#10785)
  test: add command for single cy test run (#10813)
  docs: fix TimelineGrowingMode enum docs (#10815)
  fix(ui5-side-navigation): remove inappropriate exclamation mark usage (#10769)
  feat(ui5-link): introduce reactive area size property (#10762)
  fix(ui5-side-navigation): "Space" key triggers links (#10767)
  chore(ui5-timeline): importing a timeline group item in the samples (#10793)
  chore: add ElementInternals shim (#10782)
  chore: fix MultiInput test (#10791)
  Translation Delivery (#10772)
  chore(ui5-select): remove unused css vars (#10789)
  chore: warn when scoping suffix is set too late (#10781)
  fix(ui5-button): remove tap highlight on safari (#10786)
  feat(ui5-table): action header cell is added (#10698)
  docs: fix List sample
  chore(release): publish v2.8.0-rc.0 [ci skip]
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.8.0-rc.1 🎉

The release is available on v2.8.0-rc.1

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeodorTaushanov TeodorTaushanov TeodorTaushanov approved these changes

@dimovpetar dimovpetar Awaiting requested review from dimovpetar

@nnaydenow nnaydenow Awaiting requested review from nnaydenow

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ui5-side-navigation]: inappropriate exclamation mark usage
3 participants
@LidiyaGeorgieva @ui5-webcomponents-bot @TeodorTaushanov