Skip to content

Commit

Permalink
Merge branch 'main' of https://github.com/SAP/ui5-webcomponents into …
Browse files Browse the repository at this point in the history
…ui5-settings

* 'main' of https://github.com/SAP/ui5-webcomponents:
  refactor(ui5-multi-combobox): switch to .tsx (#10807)
  refactor(ListItem): delete unused code (#10796)
  chore(deps-dev): bump esbuild from 0.19.9 to 0.25.0 (#10816)
  chore(deps-dev): bump vitest from 3.0.2 to 3.0.5 (#10785)
  test: add command for single cy test run (#10813)
  docs: fix TimelineGrowingMode enum docs (#10815)
  fix(ui5-side-navigation): remove inappropriate exclamation mark usage (#10769)
  feat(ui5-link): introduce reactive area size property (#10762)
  fix(ui5-side-navigation): "Space" key triggers links (#10767)
  chore(ui5-timeline): importing a timeline group item in the samples (#10793)
  chore: add ElementInternals shim (#10782)
  chore: fix MultiInput test (#10791)
  Translation Delivery (#10772)
  chore(ui5-select): remove unused css vars (#10789)
  chore: warn when scoping suffix is set too late (#10781)
  fix(ui5-button): remove tap highlight on safari (#10786)
  feat(ui5-table): action header cell is added (#10698)
  docs: fix List sample
  chore(release): publish v2.8.0-rc.0 [ci skip]
  • Loading branch information
dobromiraboycheva committed Feb 11, 2025
2 parents 16bbee5 + f021ca5 commit cf8e3bd
Show file tree
Hide file tree
Showing 193 changed files with 1,548 additions and 734 deletions.
19 changes: 19 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,25 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [2.8.0-rc.0](https://github.com/SAP/ui5-webcomponents/compare/v2.7.0...v2.8.0-rc.0) (2025-02-06)


### Bug Fixes

* **ui5-avatar:** announce initials ([#10755](https://github.com/SAP/ui5-webcomponents/issues/10755)) ([a14325b](https://github.com/SAP/ui5-webcomponents/commit/a14325ba15d58ec155814edb07f1cab4c8cdf4bf))
* **ui5-button-badge:** remove text when in attention dot mode ([#10768](https://github.com/SAP/ui5-webcomponents/issues/10768)) ([641fac8](https://github.com/SAP/ui5-webcomponents/commit/641fac8c3590da3e796164219520a75e10da5407))
* **ui5-flexible-column-layout:** adjust grip minimum target size ([#10743](https://github.com/SAP/ui5-webcomponents/issues/10743)) ([aa58291](https://github.com/SAP/ui5-webcomponents/commit/aa58291abd89c20c00822c2d78bed16dc32251ee)), closes [#10669](https://github.com/SAP/ui5-webcomponents/issues/10669)
* **ui5-timeline:** enhance keyboard navigation ([#10746](https://github.com/SAP/ui5-webcomponents/issues/10746)) ([0ebc0f4](https://github.com/SAP/ui5-webcomponents/commit/0ebc0f42d3e8ed5dec44bc4a56601718f22840e3))


### Features

* **ui5-input:** visual selection on type-ahead ([#10675](https://github.com/SAP/ui5-webcomponents/issues/10675)) ([1b2cd71](https://github.com/SAP/ui5-webcomponents/commit/1b2cd71de2a71b8296bcc2a19f152d3670c00c7b))





# [2.7.0](https://github.com/SAP/ui5-webcomponents/compare/v2.7.0-rc.2...v2.7.0) (2025-02-03)


Expand Down
2 changes: 1 addition & 1 deletion lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"packages/create-package",
"packages/compat"
],
"version": "2.7.0",
"version": "2.8.0-rc.0",
"command": {
"publish": {
"allowBranch": "*",
Expand Down
8 changes: 8 additions & 0 deletions packages/ai/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [2.8.0-rc.0](https://github.com/SAP/ui5-webcomponents/compare/v2.7.0...v2.8.0-rc.0) (2025-02-06)

**Note:** Version bump only for package @ui5/webcomponents-ai





# [2.7.0](https://github.com/SAP/ui5-webcomponents/compare/v2.7.0-rc.2...v2.7.0) (2025-02-03)

**Note:** Version bump only for package @ui5/webcomponents-ai
Expand Down
13 changes: 7 additions & 6 deletions packages/ai/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ui5/webcomponents-ai",
"version": "2.7.0",
"version": "2.8.0-rc.0",
"description": "UI5 Web Components: webcomponents.ai",
"ui5": {
"webComponentsPackage": true
Expand All @@ -27,6 +27,7 @@
"bundle": "nps build.bundle",
"test": "nps test-cy-ci",
"test:cypress": "nps test-cy-ci",
"test:cypress:single": "nps test-cy-single",
"test:cypress:open": "nps test-cy-open",
"test:ssr": "node -e \"import('./test/ssr/component-imports.js')\"",
"create-ui5-element": "wc-create-ui5-element",
Expand All @@ -47,13 +48,13 @@
"directory": "packages/ai"
},
"dependencies": {
"@ui5/webcomponents": "2.7.0",
"@ui5/webcomponents-base": "2.7.0",
"@ui5/webcomponents-icons": "2.7.0",
"@ui5/webcomponents-theming": "2.7.0"
"@ui5/webcomponents": "2.8.0-rc.0",
"@ui5/webcomponents-base": "2.8.0-rc.0",
"@ui5/webcomponents-icons": "2.8.0-rc.0",
"@ui5/webcomponents-theming": "2.8.0-rc.0"
},
"devDependencies": {
"@ui5/webcomponents-tools": "2.7.0",
"@ui5/webcomponents-tools": "2.8.0-rc.0",
"chromedriver": "^131.0.0"
}
}
8 changes: 8 additions & 0 deletions packages/base/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [2.8.0-rc.0](https://github.com/SAP/ui5-webcomponents/compare/v2.7.0...v2.8.0-rc.0) (2025-02-06)

**Note:** Version bump only for package @ui5/webcomponents-base





# [2.7.0](https://github.com/SAP/ui5-webcomponents/compare/v2.7.0-rc.2...v2.7.0) (2025-02-03)


Expand Down
4 changes: 2 additions & 2 deletions packages/base/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ui5/webcomponents-base",
"version": "2.7.0",
"version": "2.8.0-rc.0",
"description": "UI5 Web Components: webcomponents.base",
"author": "SAP SE (https://www.sap.com)",
"license": "Apache-2.0",
Expand Down Expand Up @@ -57,7 +57,7 @@
},
"devDependencies": {
"@openui5/sap.ui.core": "1.120.17",
"@ui5/webcomponents-tools": "2.7.0",
"@ui5/webcomponents-tools": "2.8.0-rc.0",
"chromedriver": "^131.0.0",
"clean-css": "^5.2.2",
"copy-and-watch": "^0.1.5",
Expand Down
5 changes: 5 additions & 0 deletions packages/base/src/CustomElementsRegistry.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ const isTagRegistered = (tag: string) => {
return Definitions.has(tag);
};

const hasRegisteredTags = () => {
return Definitions.size > 0;
};

const getAllRegisteredTags = () => {
return [...Definitions.values()];
};
Expand Down Expand Up @@ -93,6 +97,7 @@ const displayFailedRegistrations = () => {
export {
registerTag,
isTagRegistered,
hasRegisteredTags,
getAllRegisteredTags,
recordTagRegistrationFailure,
};
10 changes: 9 additions & 1 deletion packages/base/src/CustomElementsScopeUtils.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { hasRegisteredTags } from "./CustomElementsRegistry.js";
import VersionInfo from "./generated/VersionInfo.js";

let suf: string;
Expand All @@ -16,7 +17,9 @@ const tagsCache = new Map<string, boolean>(); // true/false means the tag should

/**
* Sets the suffix to be used for custom elements scoping, f.e. pass "demo" to get tags such as "ui5-button-demo".
* Note: by default all tags starting with "ui5-" will be scoped, unless you change this by calling "setCustomElementsScopingRules"
*
* **Note:** By default all tags starting with "ui5-" will be scoped, unless you change this by calling "setCustomElementsScopingRules"
* **Note:** Setting the scoping suffix must be done before importing any components.
*
* @public
* @param suffix The scoping suffix
Expand All @@ -26,6 +29,11 @@ const setCustomElementsScopingSuffix = (suffix: string) => {
throw new Error("Only alphanumeric characters and dashes allowed for the scoping suffix");
}

if (hasRegisteredTags()) {
// eslint-disable-next-line no-console
console.warn("Setting the scoping suffix must be done before importing any components. For proper usage, read the scoping section: https://github.com/SAP/ui5-webcomponents/blob/main/docs/2-advanced/06-scoping.md.");
}

suf = suffix;
};

Expand Down
7 changes: 6 additions & 1 deletion packages/base/src/ssr-dom-shim.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* eslint-disable max-classes-per-file */
import { HTMLElement, Element, customElements } from "@lit-labs/ssr-dom-shim";
import { HTMLElement, Element, customElements, ElementInternals } from "@lit-labs/ssr-dom-shim";

globalThis.HTMLElement ??= HTMLElement;
globalThis.Element ??= Element;
Expand Down Expand Up @@ -63,3 +63,8 @@ globalThis.ResizeObserver = class ResizeObserver {

// empty showPopover method
globalThis.HTMLElement.prototype.showPopover = function () {};

// ElementInternals
globalThis.HTMLElement.prototype.attachInternals = function() {
return new ElementInternals();
}
8 changes: 8 additions & 0 deletions packages/compat/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [2.8.0-rc.0](https://github.com/SAP/ui5-webcomponents/compare/v2.7.0...v2.8.0-rc.0) (2025-02-06)

**Note:** Version bump only for package @ui5/webcomponents-compat





# [2.7.0](https://github.com/SAP/ui5-webcomponents/compare/v2.7.0-rc.2...v2.7.0) (2025-02-03)

**Note:** Version bump only for package @ui5/webcomponents-compat
Expand Down
12 changes: 6 additions & 6 deletions packages/compat/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ui5/webcomponents-compat",
"version": "2.7.0",
"version": "2.8.0-rc.0",
"description": "UI5 Web Components: webcomponents.compat",
"ui5": {
"webComponentsPackage": true
Expand Down Expand Up @@ -45,13 +45,13 @@
"directory": "packages/compat"
},
"dependencies": {
"@ui5/webcomponents": "2.7.0",
"@ui5/webcomponents-base": "2.7.0",
"@ui5/webcomponents-icons": "2.7.0",
"@ui5/webcomponents-theming": "2.7.0"
"@ui5/webcomponents": "2.8.0-rc.0",
"@ui5/webcomponents-base": "2.8.0-rc.0",
"@ui5/webcomponents-icons": "2.8.0-rc.0",
"@ui5/webcomponents-theming": "2.8.0-rc.0"
},
"devDependencies": {
"@ui5/webcomponents-tools": "2.7.0",
"@ui5/webcomponents-tools": "2.8.0-rc.0",
"chromedriver": "^131.0.0"
}
}
8 changes: 8 additions & 0 deletions packages/create-package/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [2.8.0-rc.0](https://github.com/SAP/ui5-webcomponents/compare/v2.7.0...v2.8.0-rc.0) (2025-02-06)

**Note:** Version bump only for package @ui5/create-webcomponents-package





# [2.7.0](https://github.com/SAP/ui5-webcomponents/compare/v2.7.0-rc.2...v2.7.0) (2025-02-03)

**Note:** Version bump only for package @ui5/create-webcomponents-package
Expand Down
2 changes: 1 addition & 1 deletion packages/create-package/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ui5/create-webcomponents-package",
"version": "2.7.0",
"version": "2.8.0-rc.0",
"description": "UI5 Web Components: create package",
"author": "SAP SE (https://www.sap.com)",
"license": "Apache-2.0",
Expand Down
12 changes: 12 additions & 0 deletions packages/fiori/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,18 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [2.8.0-rc.0](https://github.com/SAP/ui5-webcomponents/compare/v2.7.0...v2.8.0-rc.0) (2025-02-06)


### Bug Fixes

* **ui5-flexible-column-layout:** adjust grip minimum target size ([#10743](https://github.com/SAP/ui5-webcomponents/issues/10743)) ([aa58291](https://github.com/SAP/ui5-webcomponents/commit/aa58291abd89c20c00822c2d78bed16dc32251ee)), closes [#10669](https://github.com/SAP/ui5-webcomponents/issues/10669)
* **ui5-timeline:** enhance keyboard navigation ([#10746](https://github.com/SAP/ui5-webcomponents/issues/10746)) ([0ebc0f4](https://github.com/SAP/ui5-webcomponents/commit/0ebc0f42d3e8ed5dec44bc4a56601718f22840e3))





# [2.7.0](https://github.com/SAP/ui5-webcomponents/compare/v2.7.0-rc.2...v2.7.0) (2025-02-03)


Expand Down
5 changes: 3 additions & 2 deletions packages/fiori/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

[![npm Package Version](https://badge.fury.io/js/%40ui5%2Fwebcomponents.svg)](https://www.npmjs.com/package/@ui5/webcomponents)

Provides essential building blocks, necessary to implement the Fiori UX concept,
Provides essential building blocks, necessary to implement the Fiori UX concept,
such as a common header (ShellBar).

## Provided components
## Provided components

| Web Component | Tag name | Module import |
|-------------------------------------------|--------------------------------|-----------------------------------------------------------------------|
Expand Down Expand Up @@ -33,6 +33,7 @@ such as a common header (ShellBar).
| Side Navigation Group | `ui5-side-navigation-group` | `import "@ui5/webcomponents-fiori/dist/SideNavigationGroup.js";` |
| Timeline | `ui5-timeline` | `import "@ui5/webcomponents-fiori/dist/Timeline.js";` |
| Timeline Item | `ui5-timeline-item` | comes with `ui5-timeline` |
| Timeline Group Item | `ui5-timeline-group-item` | `import "@ui5/webcomponents-fiori/dist/TimelineGroupItem.js";` |
| Upload Collection | `ui5-upload-collection` | `import "@ui5/webcomponents-fiori/dist/UploadCollection.js";` |
| Upload Collection Item | `ui5-upload-collection-item` | `import "@ui5/webcomponents-fiori/dist/UploadCollectionItem.js";` |
| User Menu | `ui5-user-menu` | `import "@ui5/webcomponents-fiori/dist/UserMenu.js";` |
Expand Down
88 changes: 88 additions & 0 deletions packages/fiori/cypress/specs/SideNavigation.cy.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,94 @@ describe("Side Navigation interaction", () => {
});
});

it("Tests link opening with mouse click", () => {
cy.mount(
<SideNavigation id="sideNav">
<SideNavigationItem id="item" text="1" />
<SideNavigationItem id="unselectableItemWithLink" text="external link" unselectable={true} href="#test"/>
</SideNavigation>
);

cy.url().should("not.include", "#test");

cy.get("#unselectableItemWithLink").realClick();

cy.url().should("include", "#test");

// Remove #test from the URL
cy.window().then(win => {
win.history.back();
});

cy.url().should("not.include", "#test");
});

it("Tests link opening with Enter", () => {
cy.mount(
<SideNavigation>
<SideNavigationItem id="focusStart" text="focus start" />
<SideNavigationItem text="external link" unselectable={true} href="#test"/>
</SideNavigation>
);

cy.url().should("not.include", "#test");

cy.get("#focusStart").realClick();
cy.realPress("ArrowDown");
cy.realPress("Enter");

cy.url().should("include", "#test");

// Remove #test from the URL
cy.window().then(win => {
win.history.back();
});

cy.url().should("not.include", "#test");
});

it("Tests link opening with Space", () => {
cy.mount(
<SideNavigation>
<SideNavigationItem id="focusStart" text="focus start" />
<SideNavigationItem id="linkItem" text="external link" unselectable={true} href="#test"/>
</SideNavigation>
);

cy.url().should("not.include", "#test");

cy.get("#focusStart").realClick();
cy.realPress("ArrowDown");
cy.realPress("Space");

cy.url().should("include", "#test");

// Remove #test from the URL
cy.window().then(win => {
win.history.back();
});

cy.url().should("not.include", "#test");

cy.get("#focusStart").realClick();
cy.realPress("ArrowDown");
cy.get("#linkItem").should("be.focused");

// act
cy.focused().trigger("keyup", {
key: " ",
});

cy.url().should("include", "#test");

// Remove #test from the URL
cy.window().then(win => {
win.history.back();
});

cy.url().should("not.include", "#test");
});

it("Tests 'selection-change' event", () => {
cy.mount(
<SideNavigation id="sideNav">
Expand Down
Loading

0 comments on commit cf8e3bd

Please sign in to comment.