-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING] Make namespace mandatory for application and library projects #430
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e619b32
[BREAKING] Make namespace mandatory for application and library projects
svbender 9901f91
[BREAKING] Make namespace mandatory for application and library projects
svbender bb1bc76
Add Test for getNamespace call
tobiasso85 3c2f3a1
Add Test for getCopyright call
tobiasso85 d7c7ebf
re-added test for getNamespace
tobiasso85 7b8fc99
add test for ApplicationFormatter#getSourceBasePath
tobiasso85 7773b4e
add test for LibraryFormatter#getLibraryJsPath and getDotLibrary
tobiasso85 680dcd1
Updating unit test to check if getDotLibrary works when loading from …
svbender cc69b79
Updating unit test to check if getDotLibrary works when loading from …
svbender File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this testing exactly? The caching mechanism inside
getDotLibrary
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But if I remove the caching here:
ui5-builder/lib/types/library/LibraryFormatter.js
Lines 243 to 245 in 7773b4e
The test will still be successful because it doesn't actually test whether something got cached (e.g. no second glob call).
Also, there is already tests for this. It just seem to be incorrect since its missing a second call:
ui5-builder/test/lib/types/library/LibraryFormatter.js
Line 344 in 7773b4e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exactly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...
So we gonna fix the existing test instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍