[BREAKING] Make namespace mandatory for application and library projects #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: UI5 Project must be able to determine the project's namespace, otherwise an error is thrown.
BREAKING CHANGE: UI5 Project must be able to determine the project's namespace, otherwise an error is thrown.
To increase the test coverage again
To increase the test coverage again
getNamespace: from manifest.json with not matching file path
RandomByte
previously approved these changes
Mar 17, 2020
RandomByte
dismissed
their stale review
Actually, since @matz3 is owner of the UI5 Builder, let's wait for his review as well
RandomByte
reviewed
Mar 17, 2020
| @@ -284,6 +284,21 @@ test("getDotLibrary: reads correctly", async (t) => { | |||
| t.deepEqual(fsPath, expectedPath, ".library fsPath is correct"); | |||
| }); | |||
|
|
|||
| test("getDotLibrary: reads correctly call again", async (t) => { | |||
There was a problem hiding this comment.
What is this testing exactly? The caching mechanism inside getDotLibrary?
There was a problem hiding this comment.
But if I remove the caching here:
ui5-builder/lib/types/library/LibraryFormatter.js
Lines 243 to 245 in 7773b4e
The test will still be successful because it doesn't actually test whether something got cached (e.g. no second glob call).
Also, there is already tests for this. It just seem to be incorrect since its missing a second call:
There was a problem hiding this comment.
exactly
...
So we gonna fix the existing test instead?
RandomByte
approved these changes
Mar 19, 2020
RandomByte
added a commit
to SAP/ui5-project
that referenced
this pull request
Mar 23, 2020
Tests are failing due to SAP/ui5-builder#430 Adopt tests to provide necessary manifest.json files and expect the corresponding namespace information.
RandomByte
added a commit
to SAP/ui5-server
that referenced
this pull request
Mar 23, 2020
Tests are failing due to SAP/ui5-builder#430 Adopt tests fixture to provide necessary manifest.json file.
RandomByte
added a commit
to SAP/ui5-project
that referenced
this pull request
Mar 24, 2020
Tests are failing due to SAP/ui5-builder#430 Adopt tests to provide necessary manifest.json files and expect the corresponding namespace information.
RandomByte
added a commit
to SAP/ui5-server
that referenced
this pull request
Mar 24, 2020
Tests are failing due to SAP/ui5-builder#430 Adopt tests fixture to provide necessary manifest.json file.
RandomByte
added a commit
to SAP/ui5-project
that referenced
this pull request
Mar 24, 2020
Tests are failing due to SAP/ui5-builder#430 Adopt tests to provide necessary manifest.json files and expect the corresponding namespace information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
UI5 Project must be able to determine the project's namespace,
otherwise an error is thrown.