Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ops: SourceClear Security Validation - dependency lib. vulnerability - CHOWNR #648

Closed
ivijan opened this issue Sep 5, 2018 · 3 comments
Closed

Comments

@ivijan
Copy link

ivijan commented Sep 5, 2018

Detailed description

https://sap.sourceclear.io/

SourceClear scanning for vulnerability issues reports issue with transitive dependency library chownr that is dependency of npm that is defined in package.json under "engines" node.

Additional information

"engines": { "npm": ">=9.5.0 <10.0.0" }

Vulnerability issues: Time Of Check To Time Of Use (TOCTOU)

screen shot 2018-09-05 at 15 13 28

@saad-mo
Copy link
Contributor

saad-mo commented Sep 5, 2018

@ivijan we changed npm as an engine versus a direct dependency to the project as suggested in #478. We also thought it will help resolve #591, but it didn't help much.

Do you have a suggestion on how we can address all these three issues? (#478, #591 and #648)

@saad-mo saad-mo added the Bug label Sep 11, 2018
@saad-mo saad-mo added the Ops label Sep 11, 2018
@saad-mo saad-mo changed the title SourceClear Security Validation - dependency lib. vulnerability - CHOWNR Ops: SourceClear Security Validation - dependency lib. vulnerability - CHOWNR Sep 11, 2018
@ivijan
Copy link
Author

ivijan commented Sep 14, 2018

Hello @saadmhybris,
It is great that the topic of npm vulnerabilities is already known and processed.
I will also investigate the topic on the side, and if I find something, I will come back to you.

@saad-mo
Copy link
Contributor

saad-mo commented Feb 14, 2019

This issue has been addressed.

@saad-mo saad-mo closed this as completed Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants