Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ops: Remove npm from dependencies #478

Closed
tobi-or-not-tobi opened this issue Jun 7, 2018 · 0 comments
Closed

Ops: Remove npm from dependencies #478

tobi-or-not-tobi opened this issue Jun 7, 2018 · 0 comments
Assignees
Labels
Milestone

Comments

@tobi-or-not-tobi
Copy link

npm is given as a pure dependency in this project (package.json), not sure why. When npm is added as a dependency it will be part of the npm audit process. This process is currently complaining about 5 vulnerability caused by the npm version of fundamental-ui.

If the intend is to ensure consumers of the library are using the correct npm version to build this library, I recommend to add an engine to the package.json, see https://docs.npmjs.com/files/package.json#engines for more info. It would be nice to have support for the latest npm version.

@saad-mo saad-mo changed the title Remove npm from dependencies Ops: Remove npm from dependencies Jun 7, 2018
@saad-mo saad-mo added the Ops label Jun 7, 2018
@saad-mo saad-mo added this to the Release 1.1.0 milestone Jun 8, 2018
@saad-mo saad-mo removed this from the Release 1.1.0 milestone Jun 27, 2018
@saad-mo saad-mo self-assigned this Aug 7, 2018
@saad-mo saad-mo added this to the Release 1.2.0 milestone Aug 7, 2018
saad-mo pushed a commit that referenced this issue Aug 10, 2018
eboyer added a commit that referenced this issue Aug 14, 2018
#478 remove npm as a dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants