feat: Support PEM certificates for ClientCertificateAuthentication #4473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomfrenken
reviewed
Feb 6, 2024
| pfx?: Buffer; | ||
| passphrase?: string; | ||
| } | ||
| | { |
There was a problem hiding this comment.
Currently, every single parameter is optional, if one of the two options is chosen, isn't every single parameter required? Or can you have e.g. a pfx cert without passphrase or cert & key but no passphrase?
There was a problem hiding this comment.
Might even create a type for these two objects to make it a little more concise in the function API.
tomfrenken
approved these changes
Feb 6, 2024
This was referenced Feb 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently I am using the whole file for both the key and certificate. That way we don’t have to parse the content of the certificate and it seems that the https agent can parse it on its own.
Closes https://github.com/SAP/cloud-sdk-backlog/issues/1178.