Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update winston #205

Merged
merged 2 commits into from
Jun 23, 2020
Merged

chore: Update winston #205

merged 2 commits into from
Jun 23, 2020

Conversation

marikaner
Copy link
Contributor

@marikaner marikaner commented Jun 22, 2020

Context

As we have seen in the past, lodash is broken from a security perspective. The winston update fixes that.
Unfortunately in v3.3.1 of winston the maintainer added a git dependency that is causing pipelines of customers to fail.

This locks the winston version to the one healthy version 3.3.0. Locking is not necessary anymore since v3.3.2.
Closes SAP/cloud-sdk#206

Definition of Done

Please consider all items and remove only if not applicable.

  • Tests created/adjusted for your changes.
  • Release notes updated.
    • Provide sufficient context so that each entry can be understood on its own.
    • Be specific about names of functions, classes, modules, etc.
    • Describe when or where this is relevant
    • Use indicative and present tense. For example, write "Provide function name that does X in order to Y" over "Now X can be done by calling a new function".
  • PR title adheres to conventional commit guidelines (please note that only fix: and feat: will end up in the release notes)
  • If applicable: Properly documented (JSDoc of public API)
  • If applicable: Check if node run doc still works.

@marikaner marikaner changed the title chore: Update and lock winston to a specific version chore: Update winston Jun 22, 2020
@marikaner marikaner merged commit 98edf67 into master Jun 23, 2020
@marikaner marikaner deleted the update-winston branch June 23, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with winston dependency breaking builds relying on cloud-sdk/util
2 participants