Issue with winston dependency breaking builds relying on cloud-sdk/util

[edonadei]

Describe the bug
Winston dependencies break multiples jenkins builds since the update 3.3.0/3.3.1 to winstonjs/winston#1814

Expected behavior
We should use the cloud-sdk dependency without errors from this dependency
It is actually "winston": "^3.2.1" but it should be "winston": "3.2.1" or "winston": "~3.2.1"

Used Versions:

• @sap/[email protected] but it happens on other versions aswell

[marikaner]

Hey @edonadei, I locked the version to 3.3.0. We will probably release a new version tomorrow or Wednesday. You will have to upgrade to the latest version of the SDK though, which will then be 1.22.0. As you are using a very old version, consider the migration guide.

[HoffmannThomas]

There is a fixed version available now: winstonjs/winston#1814 (comment)

[marikaner]

@marikaner I think 3.3.0 has the same issue. The last one that worked was 3.2.1.

I checked the code, the reference to git was introduced in v3.3.1 and fixed in v3.3.2, so theoretically your builds should work without any action now. If there is still something broken, maybe it is related to something else?

[HoffmannThomas]

@marikaner I think 3.3.0 has the same issue. The last one that worked was 3.2.1.

I checked the code, the reference to git was introduced in v3.3.1 and fixed in v3.3.2, so theoretically your builds should work without any action now. If there is still something broken, maybe it is related to something else?

Yeah sorry that was a misfire on my part. It worked with npm install + resolution, but our preinstall resolution script was ignored during an explicit npm install of the module inside of our pipeline.

So yes, only 3.3.1 was affected and our builds are running fine after the release of 3.3.2 without any action on our side (since the sdk defined "winston@^3.2.1").