New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge pull request #14 from antihax/fix" #20

Merged

bsrdjan merged 1 commit into SAP-archive:master from databus23:revert-pr-14

Apr 1, 2020

Contributor

databus23 commented Mar 24, 2020 •

edited

Loading

The merged PR caused multiple compilation errors:

 go test -v ./gorfc
# github.com/SAP/gorfc/gorfc [github.com/SAP/gorfc/gorfc.test]
gorfc/gorfc.go:305:2: undefined: rc
gorfc/gorfc.go:305:37: undefined: length
gorfc/gorfc.go:305:75: undefined: utf8str
gorfc/gorfc.go:305:87: undefined: utf8Size
gorfc/gorfc.go:307:5: undefined: rc
FAIL	github.com/SAP/gorfc/gorfc [build failed]

Given that it also changes quite a lot without a proper test suite I propose to revert the committed changes and review the changes in more detail.


          Revert "Merge pull request SAP-archive#14 from antihax/fix"

56ae987

This reverts commit 2617008, reversing
changes made to 6fcb5cd.

bsrdjan merged commit d5c3c95 into SAP-archive:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet