Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken build with v750 and cleanup some code #14

Merged
merged 6 commits into from
Mar 23, 2020

Conversation

antihax
Copy link
Contributor

@antihax antihax commented Jul 21, 2019

Fix build issues with latest Golang and SAP RFC SDK.

Cleaned up some code that ignored errors, still a few need refactoring.

Added build script for cross compiling Windows from Linux. Compiling CGO with libraries on windows is a bit awkward.

@CLAassistant
Copy link

CLAassistant commented Mar 23, 2020

CLA assistant check
All committers have signed the CLA.

@bsrdjan bsrdjan merged commit 2617008 into SAP-archive:master Mar 23, 2020
@bsrdjan
Copy link
Contributor

bsrdjan commented Mar 23, 2020

Thanks a lot @antihax !

@databus23
Copy link
Contributor

databus23 commented Mar 24, 2020

This merge broke master for me on Darwin at least. It does not compile anymore:

> go test -v ./gorfc
# github.com/SAP/gorfc/gorfc [github.com/SAP/gorfc/gorfc.test]
gorfc/gorfc.go:305:2: undefined: rc
gorfc/gorfc.go:305:37: undefined: length
gorfc/gorfc.go:305:75: undefined: utf8str
gorfc/gorfc.go:305:87: undefined: utf8Size
gorfc/gorfc.go:307:5: undefined: rc
FAIL	github.com/SAP/gorfc/gorfc [build failed]
FAIL

databus23 added a commit to databus23/gorfc that referenced this pull request Mar 24, 2020
This reverts commit 2617008, reversing
changes made to 6fcb5cd.
bsrdjan added a commit that referenced this pull request Apr 1, 2020
Revert "Merge pull request #14 from antihax/fix"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants