Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korean translation update #398

Closed
wants to merge 1 commit into from
Closed

Conversation

Hackjjang
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the gui Affects the Avalonia UI or translations. label Dec 17, 2024
@LotP1
Copy link
Contributor

LotP1 commented Dec 17, 2024

Duplicate of #389
Please don't open the same PR twice.

@Hackjjang
Copy link
Contributor Author

Are you saying to ignore what was rolled back?

@LotP1
Copy link
Contributor

LotP1 commented Dec 18, 2024

nothing was rolled back, you just didn't continue work on your old changes.
your old changes haven't been included in the main branch yet due to another upcoming change.

@LotP1
Copy link
Contributor

LotP1 commented Dec 18, 2024

to load your old changes go to your own profile, go into the ryujinx repo, and load the branch called "patch-7"

@Hackjjang Hackjjang closed this Dec 18, 2024
@Hackjjang Hackjjang mentioned this pull request Dec 19, 2024
@Hackjjang Hackjjang reopened this Dec 20, 2024
@GabCoolDude
Copy link
Collaborator

Please resolve your conflicts, the easiest way i found to do this was just to create a new branch based on GreemDev/Ryujinx and copy your changes from this PR to that branch and open a new PR, it's up to your though

@Hackjjang
Copy link
Contributor Author

Honestly, I really regret giving up on this feed at the time and closing it down because the released version didn't have Korean localization.
This is because not having to proceed with something that needs to be reworked in the long run and having it made public are two different things.

Even though I no longer need it, I am very angry about this.

@LotP1
Copy link
Contributor

LotP1 commented Dec 22, 2024

this PR and other translation PRs weren't merged into release because it would've made #391 need to re-merge the new translations, which was kinda a pain.
the changes still exist here, you can copy the exact translations you want into a new PR with the new locales system.

@Hackjjang
Copy link
Contributor Author

However, the 1.2.78 version released in the meantime was released without all the translations applied.
Until the next stable release comes out, Korean users will continue to use the untranslated public version.
Even my past translations aren't applied to the merged version.
There's no way I'm feeling good.

@LotP1
Copy link
Contributor

LotP1 commented Dec 22, 2024

Your other PR got merged into Canary, our test release stream.
They will be part of the main release stream the next time it is updated.
The internal locales change was pushed out as fast as possible to make the period of time were language PRs would be broken as tiny as possible. You, along with a few others, just got unlucky to be caught in that small window of a few days.
Your new PR that worked with the new system got released after the main Release update, so it of course couldn't be part of 1.2.78.
If you're unsatisfied with how the current project is handled feel free to make a fork and manage it yourself. Just like you we do this work for free when we have time.

@Ryubing Ryubing locked as too heated and limited conversation to collaborators Dec 22, 2024
@Hackjjang Hackjjang deleted the patch-10 branch December 22, 2024 22:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
gui Affects the Avalonia UI or translations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants