-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified locales #391
Unified locales #391
Conversation
Use 1 locales file instead of individual files for each langauge.
locales validation is now a MSBuild task instead and will run as part of the build process. The emulator will still need to be ran once to fix locales/langauges after a new addition, but will no longer crash
i doubt this will fix it
Validation project is no longer inlcuded in the solution by default. Ryujinx.csproj can/will call the validation project in a Rebuild. Should fix all issues. Left in a debug message that i will remove if all goes well.
0ff246c
to
791cb5f
Compare
As a translator, I don't see how this can be considered an improvement over the previous way of storing translations. The previous JSON format used a well-established convention which is understood by several tools for editing and managing translations. The custom format introduced in this PR leaves translators with no choice but to edit the JSON file directly, which is inefficient and error-prone (need to manually deal with newlines, escaping quotes, etc.). The advantage of making it easier to keep track of missing strings can already be achieved by directing people to use a translation editor (such as Poedit or even a simple web-based one like this). These tools typically present all strings in a tabular format which makes it very easy to see "blank spots" where the translation is missing. Furthermore, having strings belonging to different languages close to each other makes merge conflicts more likely to happen and IMO doesn't help with cognitive overhead when working on such a large file. I do hope this gets reconsidered. |
This was originally done since we're using community translators and I wanted to ease the work of getting the correct translations by giving translators more context from other languages. |
I see your point, but these problems stem from the fact that translators edit the JSON file(s) directly, which is not what they should be supposed to do. Why not set up Crowdin (or another translation platform)? That way, translators won't have to deal with JSONs because they will be automatically updated by the translation platform. The biggest problem I have with this PR is that the custom JSON format prevents translators from using the proper tools to do their job, be it a local editor like Poedit or a translation platform. |
It’s truly much more easy and user-friendly to translate now, as you can instantly access examples from other languages. Thanks! |
Use 1 locales file instead of individual files for each langauge. This makes it easier to keep track of what is missing. The PR will automatically fix missing locales and throw an error if anything is incorrect, by running the emulator. That way the person adding a new locale or new language can just run the emulator once to populate all the fields, so they can easily begin translating.
Use 1 locales file instead of individual files for each langauge.
This makes it easier to keep track of what is missing.
The PR will automatically fix missing locales and throw an error if anything is incorrect, by running the emulator. That way the person adding a new locale or new language can just run the emulator once to populate all the fields, so they can easily begin translating.