Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Swift Package Manager #41

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Package.swift
ikait committed Feb 14, 2020
commit fe96e61875a8da530aa4321801b6c8546795b7c5
21 changes: 18 additions & 3 deletions Package.swift
Original file line number Diff line number Diff line change
@@ -4,13 +4,28 @@ import PackageDescription

let package = Package(
name: "RxWebKit",
platforms: [
.iOS(.v8)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless there is a specific need (such as APIs used), it's best to leave this unspecified so that SwiftPM can set the minimum platform version to that which is supported by the toolchain.

This is especially important in the era of Xcode 12, as it drops support for iOS 8, making this package unusable with Xcode 12.

],
products: [
.library(name: "RxWebKit", targets: ["RxWebKit"])
],
dependencies: [
.package(url: "https://github.com/ReactiveX/RxSwift", from: "5.0.1")
.package(url: "https://github.com/ReactiveX/RxSwift", .upToNextMajor(from: "5.0.0")),
.package(url: "https://github.com/Quick/Quick.git", .upToNextMajor(from: "2.2.0")),
.package(url: "https://github.com/Quick/Nimble.git", .upToNextMajor(from: "8.0.0"))
],
targets: [
.target(name: "RxWebKit", dependencies: ["RxSwift", "RxCocoa"], path: "RxWebKit")
]
.target(
name: "RxWebKit",
dependencies: ["RxSwift", "RxCocoa", "RxRelay"],
path: "RxWebKit"
),
.testTarget(
name: "RxWebKitTests",
dependencies: ["RxWebKit", "Nimble", "Quick"],
path: "RxWebKitTests"
)
],
swiftLanguageVersions: [.v5]
)