-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Swift Package Manager #41
base: master
Are you sure you want to change the base?
Conversation
Hey, it's stuck here for a while. Any idea when this PR is going to be merged? |
I will have a look into this in the next couple of days |
Package.swift
Outdated
let package = Package( | ||
name: "RxWebKit", | ||
platforms: [ | ||
.iOS(.v8) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless there is a specific need (such as APIs used), it's best to leave this unspecified so that SwiftPM can set the minimum platform version to that which is supported by the toolchain.
This is especially important in the era of Xcode 12, as it drops support for iOS 8, making this package unusable with Xcode 12.
@mRs- Were you able to take a look at this? It's now October, and we're wanting to use this library with SwiftPM without forking (even though this library is extremely stable and doesn't see frequent changes) |
@mRs- pinging you again, can we get a review on this? |
Another ping. 2+ years needed in order to add a SPM support? |
This PR take over #37.